linux-kernel - [tip: irq/drivers] irqchip/bcm2712-mip: Fix OF node reference imbalance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <176060830402.709179.2013609575618730148.tip-bot2@tip-bot2>
Date: Thu, 16 Oct 2025 09:51:44 -0000
From: "tip-bot2 for Johan Hovold" <tip-bot2@...utronix.de>
To: linux-tip-commits@...r.kernel.org
Cc: Johan Hovold <johan@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
 Florian Fainelli <florian.fainelli@...adcom.com>, x86@...nel.org,
 linux-kernel@...r.kernel.org
Subject:
 [tip: irq/drivers] irqchip/bcm2712-mip: Fix OF node reference imbalance

The following commit has been merged into the irq/drivers branch of tip:

Commit-ID:     0435bcc4e5858c632c1b6d5afa637580d9779890
Gitweb:        https://git.kernel.org/tip/0435bcc4e5858c632c1b6d5afa637580d9779890
Author:        Johan Hovold <johan@...nel.org>
AuthorDate:    Mon, 13 Oct 2025 11:46:01 +02:00
Committer:     Thomas Gleixner <tglx@...utronix.de>
CommitterDate: Thu, 16 Oct 2025 11:30:37 +02:00

irqchip/bcm2712-mip: Fix OF node reference imbalance

The init callback must not decrement the reference count of the provided
irqchip OF node.

This should not cause any trouble currently, but if the driver ever
starts probe deferring it could lead to warnings about reference
underflow and saturation.

Fixes: 32c6c054661a ("irqchip: Add Broadcom BCM2712 MSI-X interrupt controller")
Signed-off-by: Johan Hovold <johan@...nel.org>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
---
 drivers/irqchip/irq-bcm2712-mip.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/irqchip/irq-bcm2712-mip.c b/drivers/irqchip/irq-bcm2712-mip.c
index 9bd7bc0..256c2d5 100644
--- a/drivers/irqchip/irq-bcm2712-mip.c
+++ b/drivers/irqchip/irq-bcm2712-mip.c
@@ -239,7 +239,6 @@ static int __init mip_of_msi_init(struct device_node *node, struct device_node *
 	int ret;
 
 	pdev = of_find_device_by_node(node);
-	of_node_put(node);
 	if (!pdev)
 		return -EPROBE_DEFER;