linux-kernel - Re: [PATCH] gpio: sifive: Support module autoloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MdUrm8fNRHcpAgNubJ+AM=iyThMe0hLLRd1vni8xbf2=Q@mail.gmail.com>
Date: Thu, 16 Oct 2025 11:59:00 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Samuel Holland <samuel.holland@...ive.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, Paul Walmsley <pjw@...nel.org>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH] gpio: sifive: Support module autoloading

On Thu, Oct 16, 2025 at 2:36 AM Samuel Holland
<samuel.holland@...ive.com> wrote:
>
> Add MODULE_DEVICE_TABLE() so the driver module can be loaded
> automatically based on a compatible string alias.
>
> Signed-off-by: Samuel Holland <samuel.holland@...ive.com>
> ---
>
>  drivers/gpio/gpio-sifive.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-sifive.c b/drivers/gpio/gpio-sifive.c
> index 94ef2efbd14f..e9a992cd4b9c 100644
> --- a/drivers/gpio/gpio-sifive.c
> +++ b/drivers/gpio/gpio-sifive.c
> @@ -260,6 +260,7 @@ static const struct of_device_id sifive_gpio_match[] = {
>         { .compatible = "sifive,fu540-c000-gpio" },
>         { },
>  };
> +MODULE_DEVICE_TABLE(of, sifive_gpio_match);
>
>  static struct platform_driver sifive_gpio_driver = {
>         .probe          = sifive_gpio_probe,
> --
> 2.47.2

It looks like it should have been part of commit 6b4c76ded358 ("gpio:
sifive: Allow building the driver as a module") in the first place. If
that's the case, would you mind resending with a Fixes: and Cc: stable
tags?

Bart