linux-kernel - Re: [PATCH] Documentation: sysrq: Remove contradicting sentence on extra /proc/sysrq-trigger characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251016101758.1441349-1-tomas.mudrunka@gmail.com>
Date: Thu, 16 Oct 2025 12:17:58 +0200
From: Tomas Mudrunka <tomas.mudrunka@...il.com>
To: corbet@....net
Cc: bagasdotme@...il.com,
	cengiz@...nel.wtf,
	gregkh@...uxfoundation.org,
	jirislaby@...nel.org,
	linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org,
	mail@...elmschueler.com,
	tomas.mudrunka@...il.com
Subject: Re: [PATCH] Documentation: sysrq: Remove contradicting sentence on extra /proc/sysrq-trigger characters

Hi. I am author of that sentence and this is NACK from me.

> I'm not sure this is right - there is a warning here that additional
> characters may acquire a meaning in the future, so one should not
> develop the habit of writing them now.

As you've said... I don't see anything confusing about that.
The warning was added for a reason, because there was discussion
about some people writing extra characters in there, which might
cause issues down the line if we refactor the code in future.

> After all these years, I think
> the chances of fundamental sysrq changes are pretty small,

Actualy it is not that long since the underscore mode was added...

> but I still don't see why we would take the warning out?

Exactly. Thank you.