linux-kernel - Re: [PATCH v2 5/6] media: qcom: camss: csid: Add support for CSID 1080

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16def16e-fead-4d32-812c-5672773ef3bb@kernel.org>
Date: Thu, 16 Oct 2025 11:18:28 +0100
From: Bryan O'Donoghue <bod@...nel.org>
To: Hangxiang Ma <hangxiang.ma@....qualcomm.com>,
 Loic Poulain <loic.poulain@....qualcomm.com>, Robert Foss
 <rfoss@...nel.org>, Andi Shyti <andi.shyti@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Todor Tomov <todor.too@...il.com>,
 Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: linux-i2c@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-media@...r.kernel.org, aiqun.yu@....qualcomm.com,
 tingwei.zhang@....qualcomm.com, trilok.soni@....qualcomm.com,
 yijie.yang@....qualcomm.com, Jingyi Wang <jingyi.wang@....qualcomm.com>,
 Atiya Kailany <atiya.kailany@....qualcomm.com>
Subject: Re: [PATCH v2 5/6] media: qcom: camss: csid: Add support for CSID
 1080

On 16/10/2025 11:04, Bryan O'Donoghue wrote:
> drivers/media/platform/qcom/camss/camss-csid-gen3.c:        csid- 
>  >reg_update &= ~CSID_RUP_AUP_RDI(port_id);
> drivers/media/platform/qcom/camss/camss-csid-gen3.c:        csid- 
>  >reg_update |= CSID_RUP_AUP_RDI(port_id);
> 
> and this in your code
> 
> 
> λ ~/Development/qualcomm/qlt-kernel/ linux-stable/master-reviews- 
> oct15-25* grep aup_update drivers/media/platform/qcom/camss/*
> 
> drivers/media/platform/qcom/camss/camss-csid-1080.c:static void 
> __csid_aup_update(struct csid_device *csid, int port_id)
> drivers/media/platform/qcom/camss/camss-csid-1080.c:    csid->aup_update 
> |= AUP_RDIN << port_id;

And now that I see the code side-by-side - also please use the 
established macros and/or write a new macro to follow the established 
pattern.

There's virtually no good argument to replicate a bit shift or twiddle - 
that can be functionally decomposed and encapsulated in one place and 
subsequently reused.

---
bod