[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <176061229682.2195705.7053755296248416631.robh@kernel.org>
Date: Thu, 16 Oct 2025 05:58:16 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: broonie@...nel.org, igor.belwon@...tallysanemainliners.org,
linux-kernel@...r.kernel.org, lgirdwood@...il.com, kernel@...labora.com,
matthias.bgg@...il.com, wenst@...omium.org, devicetree@...r.kernel.org,
krzk+dt@...nel.org, lee@...nel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, conor+dt@...nel.org
Subject: Re: [PATCH v9 1/9] dt-bindings: regulator: Document MediaTek
MT6316 PMIC Regulators
On Thu, 16 Oct 2025 11:30:46 +0200, AngeloGioacchino Del Regno wrote:
> Add bindings for the regulators found in the MediaTek MT6316 PMIC,
> usually found in board designs using the MT6991 Dimensity 9400 and
> on MT8196 Kompanio SoC for Chromebooks.
>
> This chip is fully controlled by SPMI and has multiple variants
> providing different phase configurations.
>
> Reviewed-by: Chen-Yu Tsai <wenst@...omium.org>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
> .../regulator/mediatek,mt6316b-regulator.yaml | 78 +++++++++++++++++++
> .../regulator/mediatek,mt6316c-regulator.yaml | 78 +++++++++++++++++++
> .../regulator/mediatek,mt6316d-regulator.yaml | 77 ++++++++++++++++++
> 3 files changed, 233 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt6316b-regulator.yaml
> create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt6316c-regulator.yaml
> create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt6316d-regulator.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/mediatek,mt6316c-regulator.example.dtb: pmic@6 (mediatek,mt6316c-regulator): '#address-cells' does not match any of the regexes: '^pinctrl-[0-9]+$', '^vbuck(124|3)$'
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6316c-regulator.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/mediatek,mt6316b-regulator.example.dtb: pmic@8 (mediatek,mt6316b-regulator): '#address-cells' does not match any of the regexes: '^pinctrl-[0-9]+$', '^vbuck(12|34)$'
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6316b-regulator.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/mediatek,mt6316d-regulator.example.dtb: pmic@7 (mediatek,mt6316d-regulator): '#address-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6316d-regulator.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251016093054.126293-2-angelogioacchino.delregno@collabora.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Powered by blists - more mailing lists