[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20251016-visconti-viif-v13-2-ceca656b9194@toshiba.co.jp>
Date: Thu, 16 Oct 2025 11:24:39 +0900
From: Yuji Ishikawa <yuji2.ishikawa@...hiba.co.jp>
To: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@...l.toshiba>,
Yuji Ishikawa <yuji2.ishikawa@...hiba.co.jp>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Philipp Zabel <p.zabel@...gutronix.de>
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: [PATCH v13 2/7] dt-bindings: media: platform: visconti: Add
Toshiba Visconti Video Input Interface
Adds the Device Tree binding documentation that allows to describe
the Video Input Interface found in Toshiba Visconti SoCs.
Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@...hiba.co.jp>
---
Changelog v2:
- no change
Changelog v3:
- no change
Changelog v4:
- fix style problems at the v3 patch
- remove "index" member
- update example
Changelog v5:
- no change
Changelog v6:
- add register definition of BUS-IF and MPU
Changelog v7:
- remove trailing "bindings" from commit header message
- remove trailing "Device Tree Bindings" from title
- fix text wrapping of description
- change compatible to visconti5-viif
- explicitly define allowed properties for port::endpoint
Changelog v8:
- Suggestion from Krzysztof Kozlowski
- rename bindings description file
- use block style array instead of inline style
- remove clock-lane (as it is fixed at position 0)
- update sample node's name
- use lowercase hex for literals
- Suggestion from Laurent Pinchart
- update description message port::description
- remove port::endpoint::bus-type as it is fixed to <4>
- remove port::endpoint::clock-lanes from example
- add port::endpoint::data-lanes to required parameters list
- fix sequence of data-lanes: <1 2 3 4> because current driver does not support data reordering
- update port::endpoint::data-lanes::description
- remove redundant type definition for port::endpoint::data-lanes
Changelog v9:
- place "required" after "properties"
- dictionary ordering of properties
Changelog v10:
- no change
Changelog v11:
- no change
Changelog v12:
- remove property "clock-noncontinuous" as VIIF switches both modes automatically
- remove property "link-frequencies" as VIIF does not use the information
- remove reg[2] and interrupts[3] which are used for CSI2RX driver
- update example to refer csi2rx for remote-endpoint
Changelog v13:
- add entries to MAINTAINERS flle
- update email address of Nobuhiro Iwamatsu in /maintainers
- add Yuji Ishikawa to /maintainers
- remove "|-" from /description
- add definitions of clock and reset
- update /port/$ref to point port instead of port-base
- update /port/description
- remove CSI2 receiver specific definition from /port/properties/endpoint/properties because CSI2 is handled by the CSI2 driver.
- update sample dts
---
.../bindings/media/toshiba,visconti5-viif.yaml | 110 +++++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 111 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/toshiba,visconti5-viif.yaml b/Documentation/devicetree/bindings/media/toshiba,visconti5-viif.yaml
new file mode 100644
index 000000000000..92ffe844cdde
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/toshiba,visconti5-viif.yaml
@@ -0,0 +1,110 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/toshiba,visconti5-viif.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Toshiba Visconti5 SoC Video Input Interface
+
+maintainers:
+ - Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@...l.toshiba>
+ - Yuji Ishikawa <yuji2.ishikawa@...hiba.co.jp>
+
+description:
+ Toshiba Visconti5 SoC Video Input Interface (VIIF) receives videostream
+ from MIPI CSI-2 receiver device, processes the stream with image signal
+ processors (L1ISP, L2ISP), then stores pictures to main memory.
+
+properties:
+ compatible:
+ const: toshiba,visconti5-viif
+
+ reg:
+ items:
+ - description: Registers for capture control
+ - description: Registers for bus interface unit control
+ - description: Registers for Memory Protection Unit
+
+ interrupts:
+ items:
+ - description: Sync Interrupt
+ - description: Status (Error) Interrupt
+ - description: L1ISP Interrupt
+
+ clocks:
+ items:
+ - description: Common clock
+ - description: Interface clock
+ - description: L1ISP clock
+ - description: L2ISP clock
+
+ clock-names:
+ items:
+ - const: bsproc
+ - const: proc
+ - const: l1isp
+ - const: l2isp
+
+ resets:
+ items:
+ - description: Interface reset
+ - description: L1ISP reset
+ - description: L2ISP reset
+
+ reset-names:
+ items:
+ - const: core
+ - const: l1isp
+ - const: l2isp
+
+ port:
+ $ref: /schemas/graph.yaml#/properties/port
+ description:
+ Input port node with an endpoint pointing to the CSI-2 receiver.
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - port
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/toshiba,tmpv770x.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ video0: video@...00000 {
+ compatible = "toshiba,visconti5-viif";
+ reg = <0 0x1c000000 0 0x6000>,
+ <0 0x1c00e000 0 0x1000>,
+ <0 0x2417a000 0 0x1000>;
+ interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&pismu TMPV770X_CLK_VIIFBS0_PROC>,
+ <&pismu TMPV770X_CLK_VIIF0_PROC>,
+ <&pismu TMPV770X_CLK_VIIF0_L1ISP>,
+ <&pismu TMPV770X_CLK_VIIF0_L2ISP>;
+ clock-names = "bsproc", "proc", "l1isp", "l2isp";
+ resets = <&pismu TMPV770X_RESET_VIIFBS0>,
+ <&pismu TMPV770X_RESET_VIIFBS0_L1ISP>,
+ <&pismu TMPV770X_RESET_VIIFBS0_L2ISP>;
+ reset-names = "core", "l1isp", "l2isp";
+
+ port {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ video0_in: endpoint {
+ remote-endpoint = <&csi0_out>;
+ };
+ };
+ };
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index e4634a0aad74..c17c7ddba5af 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -25985,6 +25985,7 @@ M: Yuji Ishikawa <yuji2.ishikawa@...hiba.co.jp>
L: linux-media@...r.kernel.org
S: Maintained
F: Documentation/devicetree/bindings/media/toshiba,visconti5-csi2.yaml
+F: Documentation/devicetree/bindings/media/toshiba,visconti5-viif.yaml
TOSHIBA WMI HOTKEYS DRIVER
M: Azael Avalos <coproscefalo@...il.com>
--
2.34.1
Powered by blists - more mailing lists