lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2025101610-detention-dangle-cef6@gregkh>
Date: Thu, 16 Oct 2025 13:24:12 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Ryosuke Yasuoka <ryasuoka@...hat.com>
Cc: arnd@...db.de, ojeda@...nel.org, alex.gaynor@...il.com,
	boqun.feng@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com,
	lossin@...nel.org, a.hindborg@...nel.org, aliceryhl@...gle.com,
	tmgross@...ch.edu, dakr@...nel.org, viro@...iv.linux.org.uk,
	brauner@...nel.org, jack@...e.cz, rust-for-linux@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH rust-next v2 0/3] rust: miscdevice: add llseek support

On Thu, Oct 16, 2025 at 07:19:51PM +0900, Ryosuke Yasuoka wrote:
> On Wed, Oct 15, 2025 at 07:40:12AM +0200, Greg KH wrote:
> > On Wed, Oct 15, 2025 at 01:02:40PM +0900, Ryosuke Yasuoka wrote:
> > > Hi all,
> > > 
> > > This patch series add support for the llseek file operation to misc
> > > devices written in Rust.
> > 
> > Cool, but what miscdevice driver needs llseek support?  Do you have a
> > real user for this that we can see as well?
> 
> Currently no. Because lseek is one of fundamental functions for device
> driver, I think it's valuable to add support. I believe we'll have real
> users based on read, write, and this lseek support.

Char devices that use lseek are "odd", don't you agree?  There are no
such current users under drivers/misc/ and only a rare few under
drivers/char/ (the huge user of that is mem.c but we aren't going to be
reimplementing that in rust any time soon...)

So without a real user of this api, I suggest we hold-off on adding it.
Let's not add it until someone comes up with a very valid reason for it.

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ