[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7333fc2b-bc30-41bf-be09-2b9ff7c3599f@collabora.com>
Date: Thu, 16 Oct 2025 13:28:49 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Sjoerd Simons <sjoerd@...labora.com>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
Ryder Lee <ryder.lee@...iatek.com>, Jianjun Wang
<jianjun.wang@...iatek.com>, Bjorn Helgaas <bhelgaas@...gle.com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Krzysztof WilczyĆski <kwilczynski@...nel.org>,
Manivannan Sadhasivam <mani@...nel.org>,
Chunfeng Yun <chunfeng.yun@...iatek.com>, Vinod Koul <vkoul@...nel.org>,
Kishon Vijay Abraham I <kishon@...nel.org>, Lee Jones <lee@...nel.org>,
Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Lorenzo Bianconi <lorenzo@...nel.org>, Felix Fietkau <nbd@....name>
Cc: kernel@...labora.com, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-pci@...r.kernel.org,
linux-phy@...ts.infradead.org, netdev@...r.kernel.org,
Daniel Golle <daniel@...rotopia.org>, Bryan Hinton <bryan@...anhinton.com>
Subject: Re: [PATCH 15/15] arm64: dts: mediatek: mt7981b-openwrt-one: Enable
leds
Il 16/10/25 12:08, Sjoerd Simons ha scritto:
> The Openwrt One has 3 status leds at the front (red, white, green) as
> well as 2 software controlled leds for the LAN jack (amber, green).
>
> Signed-off-by: Sjoerd Simons <sjoerd@...labora.com>
> ---
> .../boot/dts/mediatek/mt7981b-openwrt-one.dts | 57 ++++++++++++++++++++++
> 1 file changed, 57 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7981b-openwrt-one.dts b/arch/arm64/boot/dts/mediatek/mt7981b-openwrt-one.dts
> index 4d1653c336e71..0c0878488ae98 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7981b-openwrt-one.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7981b-openwrt-one.dts
> @@ -43,6 +43,50 @@ reg_5v: regulator-5v {
> regulator-boot-on;
> regulator-always-on;
> };
> +
> + pwm-leds {
Please keep the nodes ordered by name.
Cheers,
Angelo
> + compatible = "pwm-leds";
> +
> + led-0 {
> + color = <LED_COLOR_ID_WHITE>;
> + default-brightness = <0>;
> + function = LED_FUNCTION_STATUS;
> + max-brightness = <255>;
> + pwms = <&pwm 0 10000>;
> + };
> +
> + led-1 {
> + color = <LED_COLOR_ID_GREEN>;
> + default-brightness = <0>;
> + function = LED_FUNCTION_STATUS;
> + max-brightness = <255>;
> + pwms = <&pwm 1 10000>;
> + };
> + };
> +
> + gpio-leds {
> + compatible = "gpio-leds";
> +
> + led-0 {
> + color = <LED_COLOR_ID_RED>;
> + function = LED_FUNCTION_STATUS;
> + gpios = <&pio 9 GPIO_ACTIVE_HIGH>;
> + };
> +
> + led-1 {
> + color = <LED_COLOR_ID_AMBER>;
> + function = LED_FUNCTION_LAN;
> + gpios = <&pio 34 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "netdev";
> + };
> +
> + led-2 {
> + color = <LED_COLOR_ID_GREEN>;
> + function = LED_FUNCTION_LAN;
> + gpios = <&pio 35 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "netdev";
> + };
> + };
> };
>
> ð {
> @@ -109,6 +153,13 @@ mux {
> };
> };
>
> + pwm_pins: pwm-pins {
> + mux {
> + function = "pwm";
> + groups = "pwm0_0", "pwm1_1";
> + };
> + };
> +
> spi2_flash_pins: spi2-pins {
> mux {
> function = "spi";
> @@ -152,6 +203,12 @@ conf {
> };
> };
>
> +&pwm {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pwm_pins>;
> + status = "okay";
> +};
> +
> &spi2 {
> pinctrl-names = "default";
> pinctrl-0 = <&spi2_flash_pins>;
>
Powered by blists - more mailing lists