linux-kernel - Re: [PATCH v7 1/4] arm64: dts: qcom: sm8750: Add USB support to SM8750 SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <176061621332.2563222.17561073478578680773.robh@kernel.org>
Date: Thu, 16 Oct 2025 07:11:52 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Krishna Kurapati PSSNV <krishna.kurapati@....qualcomm.com>
Cc: Konrad Dybcio <konradybcio@...nel.org>, 
 Wesley Cheng <quic_wcheng@...cinc.com>, nfraprado@...labora.com, 
 Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, 
 linux-kernel@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
 Eric Biggers <ebiggers@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
 Arnd Bergmann <arnd@...db.de>, 
 Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, 
 Konrad Dybcio <konrad.dybcio@....qualcomm.com>, 
 Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>, 
 Bjorn Andersson <andersson@...nel.org>, 
 Geert Uytterhoeven <geert+renesas@...der.be>, Nishanth Menon <nm@...com>, 
 Melody Olvera <melody.olvera@....qualcomm.com>, devicetree@...r.kernel.org, 
 linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v7 1/4] arm64: dts: qcom: sm8750: Add USB support to
 SM8750 SoCs


On Thu, 16 Oct 2025 13:21:19 +0530, Krishna Kurapati PSSNV wrote:
> 
> 
> On 10/16/2025 12:59 PM, Konrad Dybcio wrote:
> > On 10/15/25 12:52 PM, Krishna Kurapati wrote:
> >> From: Wesley Cheng <quic_wcheng@...cinc.com>
> >>
> >> Add the base USB devicetree definitions for SM8750 platforms.  The overall
> >> chipset contains a single DWC3 USB3 controller (rev. 200a), SS QMP PHY
> >> (rev. v8) and M31 eUSB2 PHY.  The major difference for SM8750 is the
> >> transition to using the M31 eUSB2 PHY compared to previous SoCs.
> >>
> >> Enable USB support on SM8750 MTP and QRD variants. SM8750 has a QMP combo
> >> PHY for the SSUSB path, and a M31 eUSB2 PHY for the HSUSB path.
> >>
> >> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> >> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >> Signed-off-by: Wesley Cheng <quic_wcheng@...cinc.com>
> >> Signed-off-by: Melody Olvera <melody.olvera@....qualcomm.com>
> >> Signed-off-by: Krishna Kurapati <krishna.kurapati@....qualcomm.com>
> >> ---
> >
> > [...]
> >
> >> +		usb_1: usb@...8800 {
> >> +			compatible = "qcom,sm8750-dwc3", "qcom,dwc3";
> >> +			reg = <0x0 0x0a6f8800 0x0 0x400>;
> >
> > Please resend this using the flattened model
> >
> 
> Hi Konrad,
> 
>   I didn't want to disturb an ACKed series and hence I just tested and
> resent the patches as it. I will flatten it out once this is merged.
> Hope that would be fine.
> 
> Regards,
> Krishna,
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/v6.18-rc1 (exact match)
 Base: tags/v6.18-rc1 (use --merge-base to override)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for fac1a1a1-43a9-4bec-a6be-812e7d97e807@....qualcomm.com:

arch/arm64/boot/dts/qcom/sm8750-mtp.dtb: usb@...8800 (qcom,sm8750-dwc3): clock-names: ['cfg_noc', 'core', 'iface', 'sleep', 'mock_utmi'] is too short
	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
arch/arm64/boot/dts/qcom/sm8750-mtp.dtb: usb@...8800 (qcom,sm8750-dwc3): clocks: [[36, 11], [36, 156], [36, 3], [36, 161], [36, 158]] is too short
	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
arch/arm64/boot/dts/qcom/sm8750-qrd.dtb: usb@...8800 (qcom,sm8750-dwc3): clock-names: ['cfg_noc', 'core', 'iface', 'sleep', 'mock_utmi'] is too short
	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
arch/arm64/boot/dts/qcom/sm8750-qrd.dtb: usb@...8800 (qcom,sm8750-dwc3): clocks: [[36, 11], [36, 156], [36, 3], [36, 161], [36, 158]] is too short
	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#