linux-kernel - Re: [PATCH 2/3] media: qcom: camss: add support for SM6150 camss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aedc5761-75da-42bf-9147-dcde24c8e976@kernel.org>
Date: Thu, 16 Oct 2025 14:55:20 +0100
From: Bryan O'Donoghue <bod@...nel.org>
To: Wenmeng Liu <quic_wenmliu@...lcomm.com>,
 Wenmeng Liu <wenmeng.liu@....qualcomm.com>, Robert Foss <rfoss@...nel.org>,
 Todor Tomov <todor.too@...il.com>,
 Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>
Cc: linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] media: qcom: camss: add support for SM6150 camss

On 16/10/2025 13:36, Wenmeng Liu wrote:
>>> +    case CAMSS_6150:
>>>            regs->lane_regs = &lane_regs_qcm2290[0];
>> You don't need to specify the array index for that.
>>
> Here I have only added "case CAMSS_6150:", then do I need to modify the
> part of "&lane_regs_qcm2290[0]"?

Hmm no I'm wrong - again.

Please don't be afraid to call people out on being wrong - like I am now.

Existing code is:

         case CAMSS_X1E80100:
                 regs->lane_regs = &lane_regs_x1e80100[0];
                 regs->lane_array_size = ARRAY_SIZE(lane_regs_x1e80100);
                 regs->offset = 0x1000;
                 break;
         case CAMSS_8550:
                 regs->lane_regs = &lane_regs_sm8550[0];
                 regs->lane_array_size = ARRAY_SIZE(lane_regs_sm8550);
                 regs->offset = 0x1000;

Your comment is consistent with existing code.

You may ignore the previous statement.

---
bod