linux-kernel - Re: [External] : [PATCH net-next v5 3/4] net: renesas: rswitch: add offloading for L2 switching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e04e6b9-fe60-4f5b-afae-b4c36a829c0d@oracle.com>
Date: Thu, 16 Oct 2025 20:05:50 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Michael Dege <michael.dege@...esas.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Niklas Söderlund <niklas.soderlund@...natech.se>,
        Paul Barker <paul@...rker.dev>, Andrew Lunn <andrew+netdev@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>
Subject: Re: [External] : [PATCH net-next v5 3/4] net: renesas: rswitch: add
 offloading for L2 switching

Hi Michael,

On 9/1/2025 10:28 AM, Michael Dege wrote:
> +static void rswitch_update_offload_brdev(struct rswitch_private *priv)
> +{
> +	struct net_device *offload_brdev = NULL;
> +	struct rswitch_device *rdev, *rdev2;
> +
> +	rswitch_for_all_ports(priv, rdev) {
> +		if (!rdev->brdev)
> +			continue;
> +		rswitch_for_all_ports(priv, rdev2) {
> +			if (rdev2 == rdev)
> +				break;
> +			if (rdev2->brdev == rdev->brdev) {
> +				offload_brdev = rdev->brdev;
> +				break;
> +			}
> +		}
> +		if (offload_brdev)
> +			break;
> +	}
> +
> +	if (offload_brdev == priv->offload_brdev)
> +		dev_dbg(&priv->pdev->dev,
> +			"changing l2 offload from %s to %s\n",

condition does not match the actual intent
it seems, offload_brdev != priv->offload_brdev more suitable.
I understand this code already has been merged in upstream 6.18.

> +			netdev_name(priv->offload_brdev),
> +			netdev_name(offload_brdev));
> +	else if (offload_brdev)
> +		dev_dbg(&priv->pdev->dev, "starting l2 offload for %s\n",
> +			netdev_name(offload_brdev));
> +	else if (!offload_brdev)
> +		dev_dbg(&priv->pdev->dev, "stopping l2 offload for %s\n",
> +			netdev_name(priv->offload_brdev));
> +
> +	priv->offload_brdev = offload_brdev;
> +
> +	rswitch_update_l2_offload(priv);
> +}

Thanks,
Alok