linux-kernel - linux-next: manual merge of the libcrypto tree with the crypto tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <aPJMS2QN_Our8v2l@sirena.org.uk>
Date: Fri, 17 Oct 2025 15:01:47 +0100
From: Mark Brown <broonie@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>,
	"Jason A. Donenfeld" <Jason@...c4.com>,
	Ard Biesheuvel <ardb@...nel.org>,
	Linux Crypto List <linux-crypto@...r.kernel.org>
Cc: Herbert Xu <herbert@...dor.apana.org.au>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: linux-next: manual merge of the libcrypto tree with the crypto tree

Hi all,

Today's linux-next merge of the libcrypto tree got a conflict in:

  arch/x86/crypto/aes-gcm-vaes-avx2.S

between commits:

  f6c31b7871903 ("crypto: x86/aes-gcm - add VAES+AVX2 optimized code")
  d4acd8519d2ad ("crypto: x86/aes-gcm - rename avx10 and avx10_512 to avx512")

from the crypto tree and commits:

  ae40f6df72d10 ("crypto: x86/aes-gcm - add VAES+AVX2 optimized code")
  9bc4bcca89e45 ("crypto: x86/aes-gcm - rename avx10 and avx10_512 to avx512")

from the libcrypto tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

(I'm not very confident of this resolution which was a bit bigger than
it looks from the diff below, I've no real idea about x86 assembly)

diff --cc arch/x86/crypto/aes-gcm-vaes-avx2.S
index 5ccbd85383cdd,d9754e683bde3..0000000000000
--- a/arch/x86/crypto/aes-gcm-vaes-avx2.S
+++ b/arch/x86/crypto/aes-gcm-vaes-avx2.S
@@@ -689,7 -687,7 +688,8 @@@ SYM_FUNC_END(aes_gcm_aad_update_vaes_av
  	.set	LE_CTR_PTR32,	%esi
  	.set	GHASH_ACC_PTR,	%rdx
  	.set	SRC,		%rcx	// Assumed to be %rcx.
 +					// See .Ltail_xor_and_ghash_partial_vec
+ 					// See .Ltail_xor_and_ghash_1to16bytes
  	.set	DST,		%r8
  	.set	DATALEN,	%r9d
  	.set	DATALEN64,	%r9	// Zero-extend DATALEN before using!

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)