linux-kernel - Re: [PATCH] x86/platform/uv: Use str_enabled_disabled in uv_nmi_setup_hubless

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPJRClydphemPMjy@hpe.com>
Date: Fri, 17 Oct 2025 09:23:05 -0500
From: Kyle Meyer <kyle.meyer@....com>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Steve Wahl <steve.wahl@....com>, Justin Ernst <justin.ernst@....com>,
        Dimitri Sivanich <dimitri.sivanich@....com>,
        Russ Anderson <russ.anderson@....com>,
        Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
        Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/platform/uv: Use str_enabled_disabled in
 uv_nmi_setup_hubless_intr

On Fri, Oct 17, 2025 at 11:37:12AM +0200, Thorsten Blum wrote:
> Replace hard-coded strings with the str_enabled_disabled() helper. This
> unifies the output and helps the linker with deduplication, which can
> result in a smaller binary. Additionally, silence the following
> Coccinelle/coccicheck warning reported by string_choices.cocci:
> 
>   opportunity for str_enabled_disabled(uv_pch_intr_now_enabled)
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---

Reviewed-by: Kyle Meyer <kyle.meyer@....com>

>  arch/x86/platform/uv/uv_nmi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/platform/uv/uv_nmi.c b/arch/x86/platform/uv/uv_nmi.c
> index 5c50e550ab63..565ab43fa6b4 100644
> --- a/arch/x86/platform/uv/uv_nmi.c
> +++ b/arch/x86/platform/uv/uv_nmi.c
> @@ -18,6 +18,7 @@
>  #include <linux/sched/debug.h>
>  #include <linux/slab.h>
>  #include <linux/string.h>
> +#include <linux/string_choices.h>
>  #include <linux/clocksource.h>
>  
>  #include <asm/apic.h>
> @@ -340,7 +341,7 @@ static void uv_nmi_setup_hubless_intr(void)
>  		uv_pch_intr_now_enabled ? GPIROUTNMI : 0);
>  
>  	nmi_debug("UV:NMI: GPP_D_0 interrupt %s\n",
> -		uv_pch_intr_now_enabled ? "enabled" : "disabled");
> +		str_enabled_disabled(uv_pch_intr_now_enabled));
>  }
>  
>  static struct init_nmi {
> -- 
> 2.51.0
>