linux-kernel - Re: [PATCH v5 5/7] revocable: Add fops replacement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPGsxAoZQfC6igUb@google.com>
Date: Fri, 17 Oct 2025 02:41:08 +0000
From: Tzung-Bi Shih <tzungbi@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: Benson Leung <bleung@...omium.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J . Wysocki" <rafael@...nel.org>,
	Danilo Krummrich <dakr@...nel.org>,
	Jonathan Corbet <corbet@....net>, Shuah Khan <shuah@...nel.org>,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	chrome-platform@...ts.linux.dev, linux-kselftest@...r.kernel.org,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Wolfram Sang <wsa+renesas@...g-engineering.com>,
	Simona Vetter <simona.vetter@...ll.ch>,
	Dan Williams <dan.j.williams@...el.com>,
	Jason Gunthorpe <jgg@...dia.com>
Subject: Re: [PATCH v5 5/7] revocable: Add fops replacement

On Thu, Oct 16, 2025 at 11:38:27AM -0700, Randy Dunlap wrote:
> On 10/15/25 10:42 PM, Tzung-Bi Shih wrote:
> > +/**
> > + * fs_revocable_replace() - Replace the file operations to be revocable-aware.
> > + *
> > + * Should be used only from ->open() instances.
> > + */
> > +int fs_revocable_replace(struct file *filp,
> > +			 const struct fs_revocable_operations *frops,
> > +			 struct revocable_provider **rps, size_t num_rps)
> > +{
> 
> Please add the function parameters to the kernel-doc comment to avoid
> kernel-doc warnings. E.g.:

Ah, thanks.  I didn't intend to make it a kernel-doc (as PoC code) but just
wrongly copy-n-paste around.