linux-kernel - Re: [V2] mm/khugepaged: fix comment for default scan sleep duration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251017145051.13842-1-npache@redhat.com>
Date: Fri, 17 Oct 2025 08:50:51 -0600
From: Nico Pache <npache@...hat.com>
To: lianux.mm@...il.com
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	David Hildenbrand <david@...hat.com>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	Zi Yan <ziy@...dia.com>,
	Baolin Wang <baolin.wang@...ux.alibaba.com>,
	"Liam R. Howlett" <Liam.Howlett@...cle.com>,
	Ryan Roberts <ryan.roberts@....com>,
	Dev Jain <dev.jain@....com>,
	Barry Song <baohua@...nel.org>,
	Lance Yang <lance.yang@...ux.dev>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Rik van Riel <riel@...riel.com>,
	Wei Yang <richard.weiyang@...il.com>,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [V2] mm/khugepaged: fix comment for default scan sleep duration

> The comment for khugepaged_scan_sleep_millisecs incorrectly states
> the default scan period is 30 seconds. The actual default value in the
> code is 10000ms (10 seconds).
> 
> This patch corrects the comment to match the code, preventing potential
> confusion. The incorrect comment has existed since the feature was
> first introduced.
> 
> Fixes: ba76149f47d8 ("thp: khugepaged")
> 
> Signed-off-by: wang lian <lianux.mm@...il.com>
> Suggested-by: David Hildenbrand <david@...hat.com>
> Reviewed-by: Dev Jain <dev.jain@....com>
> Reviewed-by: Wei Yang <richard.weiyang@...il.com>
> Reviewed-by: Lance Yang <lance.yang@...ux.dev>

Nice cleanup for the comments!

Acked-by: Nico Pache <npache@...hat.com>
> ---
>  mm/khugepaged.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index e947b96e1443..d635d821f611 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -67,7 +67,7 @@ enum scan_result {
>  static struct task_struct *khugepaged_thread __read_mostly;
>  static DEFINE_MUTEX(khugepaged_mutex);
>  
> -/* default scan 8*512 pte (or vmas) every 30 second */
> +/* default scan 8*HPAGE_PMD_NR ptes (or vmas) every 10 second */
>  static unsigned int khugepaged_pages_to_scan __read_mostly;
>  static unsigned int khugepaged_pages_collapsed;
>  static unsigned int khugepaged_full_scans;
>