linux-kernel - Re: [PATCH 2/4] iio: adc: Add support for the Renesas RZ/N1 ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPJdWHjjwYW5VECZ@shikoro>
Date: Fri, 17 Oct 2025 17:14:32 +0200
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Herve Codina <herve.codina@...tlin.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Magnus Damm <magnus.damm@...il.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, linux-iio@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Pascal Eberhard <pascal.eberhard@...com>,
	Miquel Raynal <miquel.raynal@...tlin.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH 2/4] iio: adc: Add support for the Renesas RZ/N1 ADC


> IMHO, I think the solution you proposed is similar in term of complexity
> to the RZN1_ADC_NO_CHANNEL approach. On my side, I would prefer the
> RZN1_ADC_NO_CHANNEL approach to keep the decoupling between IIO chan and
> ADC core chans.
> 
> That's said, I am still open to move in your direction if you still think
> it is more relevant than the RZN1_ADC_NO_CHANNEL approach. Just tell me.

Well, in deed, I like "my" approach a tad better, but I am not demanding
it. It is your driver and you have reasons to do it like you implemented
it - you chose the way, I am fine with both. But maybe add a comment
(mention the decoupling) why it was decided this way.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)