linux-kernel - Re: [PATCH v4 04/11] ASoC: cs530x: Remove unused struct members and constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4663ea33-d468-4088-a20b-f0910a4a8c4e@sirena.org.uk>
Date: Fri, 17 Oct 2025 17:28:45 +0100
From: Mark Brown <broonie@...nel.org>
To: Vitaly Rodionov <vitalyr@...nsource.cirrus.com>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>, Takashi Iwai <tiwai@...e.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	David Rhodes <david.rhodes@...rus.com>,
	Richard Fitzgerald <rf@...nsource.cirrus.com>,
	Liam Girdwood <lgirdwood@...il.com>, Rob Herring <robh@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v4 04/11] ASoC: cs530x: Remove unused struct members and
 constants

On Fri, Oct 17, 2025 at 05:15:31PM +0100, Vitaly Rodionov wrote:

>  /* Register Fields */
>  
> -/* REVID */
> -#define CS530X_MTLREVID			GENMASK(3, 0)
> -#define CS530X_AREVID			GENMASK(7, 4)
> -

It seems a bit unhelpful to remove register definitions merely because
they are removed, so long as they're correct they might come in handly
for something in the future.  I'm not sure if the datasheet for these
parts is public...

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)