linux-kernel - Re: [PATCH 4/6] mailbox: pcc: Mark Tx as complete in PCC IRQ handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <acedb8e8-3d85-4580-8dc8-52a6643de29f@amperemail.onmicrosoft.com>
Date: Fri, 17 Oct 2025 12:54:12 -0400
From: Adam Young <admiyo@...eremail.onmicrosoft.com>
To: Sudeep Holla <sudeep.holla@....com>, linux-acpi@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Adam Young <admiyo@...amperecomputing.com>,
 Robbie King <robbiek@...ghtlabs.com>, Huisong Li <lihuisong@...wei.com>,
 Jassi Brar <jassisinghbrar@...il.com>,
 Cristian Marussi <cristian.marussi@....com>
Subject: Re: [PATCH 4/6] mailbox: pcc: Mark Tx as complete in PCC IRQ handler

Tested-by: Adam Young <admiyo@...amperecomputing.com>

On 10/16/25 15:08, Sudeep Holla wrote:
> The PCC IRQ handler clears channel-in-use and notifies clients with
> mbox_chan_received_data(), but it does not explicitly mark the
> transmit as complete. In IRQ completion mode this could leave Tx complete
> waiters hanging or lead to generic timeouts in the mailbox core.
>
> Invoke mbox_chan_txdone() in the IRQ path once the platform has
> acknowledged the transfer so the core can wake any waiters and update
> state accordingly.
>
> Signed-off-by: Sudeep Holla <sudeep.holla@....com>
> ---
>   drivers/mailbox/pcc.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
> index 327e022973db..33bd2d05704b 100644
> --- a/drivers/mailbox/pcc.c
> +++ b/drivers/mailbox/pcc.c
> @@ -341,6 +341,7 @@ static irqreturn_t pcc_mbox_irq(int irq, void *p)
>   	 */
>   	pchan->chan_in_use = false;
>   	mbox_chan_received_data(chan, NULL);
> +	mbox_chan_txdone(chan, 0);
>   
>   	pcc_chan_acknowledge(pchan);
>   
>