linux-kernel - RE: [PATCH] scsi:fnic: Self-assignment of intr_time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SJ0PR11MB5896DA752A919EA96B8D24B4C3F6A@SJ0PR11MB5896.namprd11.prod.outlook.com>
Date: Fri, 17 Oct 2025 16:59:51 +0000
From: "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>
To: "liuqiangneo@....com" <liuqiangneo@....com>, "Satish Kharat (satishkh)"
	<satishkh@...co.com>, "Sesidhar Baddela (sebaddel)" <sebaddel@...co.com>,
	"James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Qiang Liu
	<liuqiang@...inos.cn>
Subject: RE: [PATCH] scsi:fnic: Self-assignment of intr_time_type has no
 effect

On Friday, October 17, 2025 12:55 AM, liuqiangneo@....com <liuqiangneo@....com> wrote:
>
>
> Remove the self-assignment statement of the intr_time_type variable
>
> Signed-off-by: Qiang Liu <liuqiang@...inos.cn>
> ---
> drivers/scsi/fnic/fnic_res.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/fnic/fnic_res.c b/drivers/scsi/fnic/fnic_res.c
> index 763475587b7f..9801e5fbb0dd 100644
> --- a/drivers/scsi/fnic/fnic_res.c
> +++ b/drivers/scsi/fnic/fnic_res.c
> @@ -134,7 +134,6 @@ int fnic_get_vnic_config(struct fnic *fnic)
> c->luns_per_tgt));
>
> c->intr_timer = min_t(u16, VNIC_INTR_TIMER_MAX, c->intr_timer);
> -     c->intr_timer_type = c->intr_timer_type;
>
> /* for older firmware, GET_CONFIG will not return anything */
> if (c->wq_copy_count == 0)
> --
> 2.43.0
>
>

Looks good to me. Thanks for the change.

Reviewed-by: Karan Tilak Kumar <kartilak@...co.com>

Regards,
Karan