linux-kernel - Re: [PATCH v4 0/4] platform/x86: acer-wmi: Add fan control support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <41a10635-09bd-41e8-a21a-9a19376b17c9@gmx.de>
Date: Fri, 17 Oct 2025 19:14:43 +0200
From: Armin Wolf <W_Armin@....de>
To: Fa-Iz Faadhillah Ibrahim <faiz.faadhillah@...il.com>, jlee@...e.com,
 basak.sb2006@...il.com, rayanmargham4@...il.com
Cc: kuurtb@...il.com, ilpo.jarvinen@...ux.intel.com,
 platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/4] platform/x86: acer-wmi: Add fan control support

Am 17.10.25 um 16:42 schrieb Fa-Iz Faadhillah Ibrahim:

> On Friday, October 17, 2025 1:00 AM Armin Wolf wrote:
>> This patch series aims to add fan control support to the acer-wmi
>> driver. The patches are compile-tested only and need to be tested
>> on real hardware to verify that they actually work.
>>
>> I CCed three users who requested support for this feature. I would be
>> very happy if one of you could test those patches and report back.
>>
>> Changes since v3:
>> - fix error in WMID_gaming_set_fan_behavior()
>>
>> Changes since v2:
>> - get rid of nested bit masks
>>
>> Changes since v1:
>> - remove unnecessary blank line
>>
>> Changes since RFC v2:
>> - improve error handling when setting fan behavior
>> - Add Reviewed-by tags
>> - whitelist PHN16-72
>>
>> Changes since RFC v1:
>> - remove duplicate include and replace hwmon_pwm_mode with
>>    hwmon_pwm_enable in second patch
>>
>> Armin Wolf (4):
>>    platform/x86: acer-wmi: Fix setting of fan behavior
>>    platform/x86: acer-wmi: Add fan control support
>>    platform/x86: acer-wmi: Enable fan control for PH16-72 and PT14-51
>>    platform/x86: acer-wmi: Add support for PHN16-72
>>
>>   drivers/platform/x86/acer-wmi.c | 292 +++++++++++++++++++++++++++++---
>>   1 file changed, 269 insertions(+), 23 deletions(-)
> Hello,
>
> I've tested your patch, had a weird thing where i need to reboot to windows
> first to make fan control works again, but it all works well now, both CPU and
> GPU fan control works just fine.
>
> Thanks,
> Fa-Iz Faadhillah Ibrahim

Good work, the reason for this fan control glitch could be that the faulty version of the acpi-wmi
driver left the ACPI firmware interface in an invalid state.

Ilpo, what do you thing about this series?

Thanks,
Armin Wolf