linux-kernel - Re: [PATCH v4 1/2] platform/x86: Add Uniwill laptop driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9e63e9de-b9af-478d-90ad-d7fca59aaea8@gmx.de>
Date: Fri, 17 Oct 2025 19:19:50 +0200
From: Armin Wolf <W_Armin@....de>
To: Nathan Chancellor <nathan@...nel.org>
Cc: kernel test robot <lkp@...el.com>, ilpo.jarvinen@...ux.intel.com,
 hdegoede@...hat.com, chumuzero@...il.com, corbet@....net, cs@...edo.de,
 wse@...edocomputers.com, ggo@...edocomputers.com, llvm@...ts.linux.dev,
 oe-kbuild-all@...ts.linux.dev, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
 rdunlap@...radead.org, alok.a.tiwari@...cle.com, linux-leds@...r.kernel.org,
 lee@...nel.org, pobrn@...tonmail.com
Subject: Re: [PATCH v4 1/2] platform/x86: Add Uniwill laptop driver

Am 06.10.25 um 21:08 schrieb Nathan Chancellor:

> On Sun, Oct 05, 2025 at 08:06:57PM +0200, Armin Wolf wrote:
>> Am 03.10.25 um 01:36 schrieb Nathan Chancellor:
>>
>>> Hi Armin,
>>>
>>> On Thu, Oct 02, 2025 at 08:41:19PM +0200, Armin Wolf wrote:
>>>> i think this is a problem inside the clang compiler. I did not encounter this warning when
>>>> build for x86-64 using gcc.
>>> Clang is actually saving you from yourself, it is a bug in GCC that it
>>> does not warn for this:
>>>
>>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91951
>> Oh my, i didn't expect that. Thank you for explaining this issue to to me,
>> it seems that i still have much to learn.
> In your defense, it is quite a subtle interaction. It is probably worth
> throwing something in the documentation that explicitly calls this out,
> though I am not immediately sure of where...
>
> Cheers,
> Nathan
>
Maybe Documentation/core-api/cleanup.rst would be a suitable place for warning
people about this.

Thanks,
Armin Wolf