linux-kernel - Re: [PATCH net-next 10/15] net: macb: remove bp->queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f4af5fd-88af-4f43-b006-c9f5733c303e@lunn.ch>
Date: Fri, 17 Oct 2025 20:11:39 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Théo Lebrun <theo.lebrun@...tlin.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Claudiu Beznea <claudiu.beznea@...on.dev>,
	Richard Cochran <richardcochran@...il.com>,
	Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>,
	Tawfik Bayouk <tawfik.bayouk@...ileye.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	Grégory Clement <gregory.clement@...tlin.com>,
	Benoît Monin <benoit.monin@...tlin.com>,
	Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next 10/15] net: macb: remove bp->queue_mask

On Tue, Oct 14, 2025 at 05:25:11PM +0200, Théo Lebrun wrote:
> The low 16 bits of GEM_DCFG6 tell us which queues are enabled in HW. In
> theory, there could be holes in the bitfield. In practice, the macb
> driver would fail if there were holes as most loops iterate upon
> bp->num_queues. Only macb_init() iterated correctly.
> 
>  - Drop bp->queue_mask field.
>  - Error out at probe if a hole is in the queue mask.
>  - Rely upon bp->num_queues for iteration.
>  - As we drop the queue_mask probe local variable, fix RCT.
>  - Compute queue_mask on the fly for TAPRIO using bp->num_queues.
> 
> Signed-off-by: Théo Lebrun <theo.lebrun@...tlin.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew