linux-kernel - Re: [PATCH] firmware: qcom: tzmem: area: fix qcom_tzmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dcb8e0ac-ed47-42a2-9882-c2cd6d6cd6fe@infradead.org>
Date: Fri, 17 Oct 2025 12:05:38 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
 Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: linux-kernel@...r.kernel.org, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] firmware: qcom: tzmem: area: fix qcom_tzmem_policy
 kernel-doc



On 10/17/25 1:25 AM, Bartosz Golaszewski wrote:
> On Fri, 17 Oct 2025 at 10:17, Konrad Dybcio
> <konrad.dybcio@....qualcomm.com> wrote:
>>
>> On 10/17/25 9:07 AM, Randy Dunlap wrote:
>>> Fix kernel-doc warnings by using correct kernel-doc syntax and
>>> formatting to prevent warnings:
>>>
>>> Warning: include/linux/firmware/qcom/qcom_tzmem.h:25 Enum value
>>>  'QCOM_TZMEM_POLICY_STATIC' not described in enum 'qcom_tzmem_policy'
>>> Warning: ../include/linux/firmware/qcom/qcom_tzmem.h:25 Enum value
>>>  'QCOM_TZMEM_POLICY_MULTIPLIER' not described in enum 'qcom_tzmem_policy'
>>> Warning: ../include/linux/firmware/qcom/qcom_tzmem.h:25 Enum value
>>>  'QCOM_TZMEM_POLICY_ON_DEMAND' not described in enum 'qcom_tzmem_policy'
>>>
>>> Fixes: 84f5a7b67b61 ("firmware: qcom: add a dedicated TrustZone buffer allocator")
>>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>>> ---
>>> Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>>> Cc: Bjorn Andersson <andersson@...nel.org>
>>> Cc: Konrad Dybcio <konradybcio@...nel.org>
>>> Cc: linux-arm-msm@...r.kernel.org
>>> ---
>>>  include/linux/firmware/qcom/qcom_tzmem.h |   12 +++++++++---
>>>  1 file changed, 9 insertions(+), 3 deletions(-)
>>>
>>> --- linux-next-20251016.orig/include/linux/firmware/qcom/qcom_tzmem.h
>>> +++ linux-next-20251016/include/linux/firmware/qcom/qcom_tzmem.h
>>> @@ -17,11 +17,17 @@ struct qcom_tzmem_pool;
>>>   * enum qcom_tzmem_policy - Policy for pool growth.
>>>   */
>>>  enum qcom_tzmem_policy {
>>> -     /**< Static pool, never grow above initial size. */
>>> +     /**
>>> +      * @QCOM_TZMEM_POLICY_STATIC: Static pool,
>>> +      * never grow above initial size. */
>>
>> Didn't know inline '*/' was cool, but if the checkers I'm happy, I'm not
>> going to complain either
>>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
>>
>> Konrad
> 
> Yes, very surprising. Almost doesn't look "right".
> 
> Anyway:
> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>

Darn. It looks OK but it totally confuses scripts/kernel-doc.
It has to end with a separate */ for each comment.
I'll have to resend this patch.

-- 
~Randy