linux-kernel - Re: [PATCH v2 3/4] arm64: dts: qcom: qcm2290: add LPASS LPI pin controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <zmi5grjg2znxddqzfsdsr35ad5olj3xgwwt6hvkiaynxzm5z33@gsgrdguj563n>
Date: Fri, 17 Oct 2025 15:42:07 -0700
From: Bjorn Andersson <andersson@...nel.org>
To: Alexey Klimov <alexey.klimov@...aro.org>
Cc: Konrad Dybcio <konrad.dybcio@....qualcomm.com>, 
	Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, Srinivas Kandagatla <srini@...nel.org>, 
	Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH v2 3/4] arm64: dts: qcom: qcm2290: add LPASS LPI pin
 controller

On Fri, Oct 10, 2025 at 01:29:38PM +0100, Alexey Klimov wrote:
> On Tue Oct 7, 2025 at 1:39 PM BST, Konrad Dybcio wrote:
> > On 10/7/25 4:03 AM, Alexey Klimov wrote:
> >> Add the Low Power Audio SubSystem Low Power Island (LPASS LPI) pin
> >> controller device node required for audio subsystem on Qualcomm
> >> QRB2210 RB1. QRB2210 is based on qcm2290 which is based on sm6115.
> >> 
> >> While at this, also add description of lpi_i2s2 pins (active state)
> >> required for audio playback via HDMI/I2S.
> >> 
> >> Cc: Srinivas Kandagatla <srini@...nel.org>
> >> Signed-off-by: Alexey Klimov <alexey.klimov@...aro.org>
> >> ---
> >
> > [...]
> >
> >> +			lpi_i2s2_active: lpi-i2s2-active-state {
> >> +				data-pins {
> >> +					pins = "gpio12";
> >> +					function = "i2s2_data";
> >> +					bias-disable;
> >> +					drive-strength = <8>;
> >> +					output-high;
> >
> > I.. doubt output-high is what you want?
> 
> Why? Or is it because of some in-kernel gpiod?
> 

What does "output-high" mean for a non-gpio function?

Regards,
Bjorn

> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sm4250.dtsi#n66
> 
> >> +				};
> >> +
> >> +				sck-pins {
> >> +					pins = "gpio10";
> >> +					function = "i2s2_clk";
> >> +					bias-disable;
> >> +					drive-strength = <8>;
> >> +					output-high;
> >> +				};
> >> +
> >> +				ws-pins {
> >> +					pins = "gpio11";
> >
> > Please re-sort pin entries by the gpio index
> >
> > https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-nodes
> 
> Ok.
> 
> Thanks,
> Alexey.
>