linux-kernel - Re: [PATCH v5] dt-bindings: mfd: qcom,spmi-pmic: add compatibles for audio blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e4e0ad1-a030-4933-8bc9-7b9782234a15@kernel.org>
Date: Fri, 17 Oct 2025 08:25:21 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alexey Klimov <alexey.klimov@...aro.org>, lee@...nel.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, sboyd@...nel.org
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, srini@...nel.org,
 krzysztof.kozlowski@...aro.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH v5] dt-bindings: mfd: qcom,spmi-pmic: add compatibles for
 audio blocks

On 17/10/2025 08:13, Alexey Klimov wrote:
> If/when pm4125 audio codec will be added to a device tree file, then dtbs
> check will emit messages that pmic audio-codec@...0 doesn't match any
> of the regexes: '^pinctrl-[0-9]+$'.

Future errors because of present mistakes are not a reason to do
something. This makes no sense because there is no DTBs with that
compatible, so drop this sentence. We never document compatibles,
because in the future they will be errors (if I get it right?).

> 
> Add the compatibles for two possible audio codecs so the devicetree for
> such audio blocks of PMIC can be validated properly while also
> removing reference to qcom,pm8916-wcd-analog-codec schema file.

And that's now incomplete. You add new device here and because preferred
and sufficient is to list compatibles, you change existing audio codec
child schema reference into just list of compatibles.

> 
> Suggested-by: Krzysztof Kozlowski <krzk@...nel.org>

I don't think I suggested this patch. What's more, it wasn't here at v4.

> Signed-off-by: Alexey Klimov <alexey.klimov@...aro.org>

Best regards,
Krzysztof