linux-kernel - Re: [PATCH] block: Remove redundant hctx pointer dereferencing operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPHh1eTQRDO3z6Yb@infradead.org>
Date: Thu, 16 Oct 2025 23:27:33 -0700
From: Christoph Hellwig <hch@...radead.org>
To: chengkaitao <pilgrimtao@...il.com>
Cc: axboe@...nel.dk, dlemoal@...nel.org, yukuai3@...wei.com,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
	Chengkaitao <chengkaitao@...inos.cn>
Subject: Re: [PATCH] block: Remove redundant hctx pointer dereferencing
 operation

On Thu, Oct 16, 2025 at 09:16:51PM +0800, chengkaitao wrote:
> From: Chengkaitao <chengkaitao@...inos.cn>
> 
> The {*q = hctx->queue} statement in the dd_insert_requestfunction is
> redundant. This patch removes the operation and modifies the function's
> formal parameters accordingly.

What formal parameters?

Basically you're passing a pointless extra argument instead of deriving
it locally.  Why would you do that?