linux-kernel - Re: [PATCH] mtd: spi-nor: atmel: add at25dn011

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DDKE72QORJS2.29XWZ4U0T0K4I@kernel.org>
Date: Fri, 17 Oct 2025 08:44:18 +0200
From: "Michael Walle" <mwalle@...nel.org>
To: "Simon Richter" <simon@...ic.eu>, "Tudor Ambarus"
 <tudor.ambarus@...aro.org>, "Pratyush Yadav" <pratyush@...nel.org>, "Miquel
 Raynal" <miquel.raynal@...tlin.com>, "Richard Weinberger" <richard@....at>,
 "Vignesh Raghavendra" <vigneshr@...com>, "Nicolas Ferre"
 <nicolas.ferre@...rochip.com>, "Alexandre Belloni"
 <alexandre.belloni@...tlin.com>, "Claudiu Beznea"
 <claudiu.beznea@...on.dev>, <linux-mtd@...ts.infradead.org>,
 <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Cc: "Marcus Folkesson" <marcus.folkesson@...il.com>
Subject: Re: [PATCH] mtd: spi-nor: atmel: add at25dn011

Hi Simon,

On Fri Oct 17, 2025 at 8:05 AM CEST, Simon Richter wrote:
> Add AT25DN011 with 1Mbit.
> Used on multiple custom boards and tested with this patch.

Could you add your testing to the next version of your patch (below
a "---" line). See also [1].

>
> Link: https://www.renesas.com/en/document/dst/at25dn011-datasheet?r=1608506

Newer flash and no SFDP :|

> Signed-off-by: Simon Richter <simon@...ic.eu>
> ---
>  drivers/mtd/spi-nor/atmel.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/atmel.c b/drivers/mtd/spi-nor/atmel.c
> index 82c592f0a1e1..0c2908bce0bc 100644
> --- a/drivers/mtd/spi-nor/atmel.c
> +++ b/drivers/mtd/spi-nor/atmel.c
> @@ -171,6 +171,11 @@ static const struct flash_info atmel_nor_parts[] = {
>  		.name = "at45db081d",
>  		.size = SZ_1M,
>  		.no_sfdp_flags = SECT_4K,
> +	}, {
> +		.id = SNOR_ID(0x1f, 0x42, 0x00),
> +		.name = "at25dn011",

No .name please, the ID is enough. We've deprecated the use of a
name.

> +		.size = SZ_128K,
> +		.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ

missing trailing comma.

-michael

>  	}, {
>  		.id = SNOR_ID(0x1f, 0x42, 0x16),
>  		.name = "at25sl321",

[1] https://docs.kernel.org/driver-api/mtd/spi-nor.html

Download attachment "signature.asc" of type "application/pgp-signature" (298 bytes)