linux-kernel - Re: [PATCH v5 07/14] gpu: nova-core: gsp: Add GSP command queue handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2uea6utj25fqhmjubke7g66sh2f7qchgnin6fgb23irfl4vxkd@zc4h3tcter3o>
Date: Fri, 17 Oct 2025 11:39:23 +1100
From: Alistair Popple <apopple@...dia.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: rust-for-linux@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	dakr@...nel.org, acourbot@...dia.com, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>, 
	Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, 
	Trevor Gross <tmgross@...ch.edu>, David Airlie <airlied@...il.com>, 
	Simona Vetter <simona@...ll.ch>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, 
	John Hubbard <jhubbard@...dia.com>, Joel Fernandes <joelagnelf@...dia.com>, 
	Timur Tabi <ttabi@...dia.com>, linux-kernel@...r.kernel.org, nouveau@...ts.freedesktop.org
Subject: Re: [PATCH v5 07/14] gpu: nova-core: gsp: Add GSP command queue
 handling

On 2025-10-17 at 05:44 +1100, Miguel Ojeda <miguel.ojeda.sandonis@...il.com> wrote...
> On Mon, Oct 13, 2025 at 8:21 AM Alistair Popple <apopple@...dia.com> wrote:
> >
> > -rust_allowed_features := asm_const,asm_goto,arbitrary_self_types,lint_reasons,offset_of_nested,raw_ref_op,used_with_arg
> > +rust_allowed_features := asm_const,asm_goto,arbitrary_self_types,lint_reasons,offset_of_nested,raw_ref_op,used_with_arg,slice_flatten
> 
> This is not sorted, and it is not mentioned in the comment right above
> it -- in general, please try to clearly mention this sort of addition
> in the commit message too.
> 
> As Alexandre mentions, it will not work to use it as-is. However, what
> happened in 1.80 was just a rename, but the feature was available
> since 1.67 as `flatten`.

Argh! Thanks, I wasn't aware the function had been renamed.

> If you want to still use it through an indirection or similar, then
> please move it to a new commit that explains the addition of the
> feature and the indirection to use it.

That makes sense, thanks for the explaination.

> See e.g. the `file()` function I added in e.g. rust/macros/helpers.rs
> in commit 36174d16f3ec ("rust: kunit: support KUnit-mapped `assert!`
> macros in `#[test]`s") to see how to set it up.
> 
> Essentially it is:
> 
>     config RUSTC_HAS_SPAN_FILE
>            def_bool RUSTC_VERSION >= 108800
> 
> And then:
> 
>     pub(crate) fn file() -> String {
>         #[cfg(not(CONFIG_RUSTC_HAS_SPAN_FILE))]
>         {
>             ...
>         }
> 
>         #[cfg(CONFIG_RUSTC_HAS_SPAN_FILE)]
>         #[allow(clippy::incompatible_msrv)]
>         {
>             ...
>         }
>     }
> 
> I hope that helps.
> 
> Thanks!
> 
> Cheers,
> Miguel