linux-kernel - Re: [PATCH v2] crypto: drbg - make drbg_{ctr_bcc,kcapi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPH7y-MX8lT6YjZr@gondor.apana.org.au>
Date: Fri, 17 Oct 2025 16:18:19 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Sergey Shtylyov <s.shtylyov@....ru>
Cc: "David S. Miller" <davem@...emloft.net>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, Karina Yankevich <k.yankevich@....ru>
Subject: Re: [PATCH v2] crypto: drbg - make drbg_{ctr_bcc,kcapi_sym}() return
 *void*

On Thu, Sep 25, 2025 at 12:00:10AM +0300, Sergey Shtylyov wrote:
> From: Karina Yankevich <k.yankevich@....ru>
> 
> drgb_kcapi_sym() always returns 0, so make it return void instead.
> Consequently, make drbg_ctr_bcc() return void too.
> 
> Found by Linux Verification Center (linuxtesting.org) with the Svace static
> analysis tool.
> 
> [Sergey: fixed the subject, refreshed the patch]
> 
> Signed-off-by: Karina Yankevich <k.yankevich@....ru>
> Signed-off-by: Sergey Shtylyov <s.shtylyov@....ru>
> 
> ---
> The patch is against the master branch of Linus Torvalds' linux.git repo
> (I'm unable to use the other repos on git.kernel.org and I have to update
> Linus' repo from GitHub).
> 
>  crypto/drbg.c |   38 ++++++++++++--------------------------
>  1 file changed, 12 insertions(+), 26 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt