linux-kernel - Re: [PATCH] crypto: aead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPH9gTi-EuL5Gd3s@gondor.apana.org.au>
Date: Fri, 17 Oct 2025 16:25:37 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: T Pratham <t-pratham@...com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Manorit Chawdhry <m-chawdhry@...com>,
	Kamlesh Gurudasani <kamlesh@...com>,
	Shiva Tripathi <s-tripathi1@...com>,
	Kavitha Malarvizhi <k-malarvizhi@...com>,
	Vishal Mahaveer <vishalm@...com>,
	Praneeth Bajjuri <praneeth@...com>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: aead - Fix reqsize handling

On Wed, Oct 08, 2025 at 03:03:14PM +0530, T Pratham wrote:
> Commit afddce13ce81d ("crypto: api - Add reqsize to crypto_alg")
> introduced cra_reqsize field in crypto_alg struct to replace type
> specific reqsize fields. It looks like this was introduced specifically
> for ahash and acomp from the commit description as subsequent commits
> add necessary changes in these alg frameworks.
> 
> However, this is being recommended for use in all crypto algs
> instead of setting reqsize using crypto_*_set_reqsize(). Using
> cra_reqsize in aead algorithms, hence, causes memory corruptions and
> crashes as the underlying functions in the algorithm framework have not
> been updated to set the reqsize properly from cra_reqsize. [1]
> 
> Add proper set_reqsize calls in the aead init function to properly
> initialize reqsize for these algorithms in the framework.
> 
> [1]: https://gist.github.com/Pratham-T/24247446f1faf4b7843e4014d5089f6b
> 
> Fixes: afddce13ce81d ("crypto: api - Add reqsize to crypto_alg")
> Signed-off-by: T Pratham <t-pratham@...com>
> ---
>  crypto/aead.c | 1 +
>  1 file changed, 1 insertion(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt