linux-kernel - Re: [PATCH] leds: upboard: fix module alias

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <256ccf82-f893-42da-890f-6e4494394cb7@kernel.org>
Date: Fri, 17 Oct 2025 11:03:02 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Thomas Richard <thomas.richard@...tlin.com>, Lee Jones <lee@...nel.org>,
 Pavel Machek <pavel@...nel.org>
Cc: Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
 DanieleCleri@...on.eu, GaryWang@...on.com.tw
Subject: Re: [PATCH] leds: upboard: fix module alias

On 17/10/2025 11:00, Thomas Richard wrote:
> On 10/16/25 9:11 PM, Krzysztof Kozlowski wrote:
>> On 16/10/2025 15:28, Thomas Richard wrote:
>>> Fix module alias for auto-loading.
>>
>> Fix what exactly? It was a completely correct alias. Please describe
>> here bug (so WHY you are doing this) not what you are doing.
> 
> The module alias does not match the cell name defined in the MFD driver,


Then this should be clearly explained.

Again: your commit msg should describe the bug, the reasons why you are
doing it, not just "fix" without telling what is wrong.


> so if the driver is built as a module, it is not automatically loaded.

Best regards,
Krzysztof