linux-kernel - Re: [PATCH v12 19/23] crypto: acomp - Add crypto_acomp_batch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPGWHWlsStefuvKL@gondor.apana.org.au>
Date: Fri, 17 Oct 2025 09:04:29 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Kanchana P Sridhar <kanchana.p.sridhar@...el.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, hannes@...xchg.org,
	yosry.ahmed@...ux.dev, nphamcs@...il.com, chengming.zhou@...ux.dev,
	usamaarif642@...il.com, ryan.roberts@....com, 21cnbao@...il.com,
	ying.huang@...ux.alibaba.com, akpm@...ux-foundation.org,
	senozhatsky@...omium.org, sj@...nel.org, kasong@...cent.com,
	linux-crypto@...r.kernel.org, davem@...emloft.net,
	clabbe@...libre.com, ardb@...nel.org, ebiggers@...gle.com,
	surenb@...gle.com, kristen.c.accardi@...el.com,
	vinicius.gomes@...el.com, wajdi.k.feghali@...el.com,
	vinodh.gopal@...el.com
Subject: Re: [PATCH v12 19/23] crypto: acomp - Add crypto_acomp_batch_size()
 to get an algorithm's batch-size.

On Thu, Sep 25, 2025 at 08:34:58PM -0700, Kanchana P Sridhar wrote:
>
> diff --git a/include/crypto/acompress.h b/include/crypto/acompress.h
> index 0f1334168f1b..e94046529e46 100644
> --- a/include/crypto/acompress.h
> +++ b/include/crypto/acompress.h
> @@ -108,6 +108,8 @@ struct acomp_req {
>   *
>   * @compress:		Function performs a compress operation
>   * @decompress:		Function performs a de-compress operation
> + * @batch_size:		Maximum batch-size for batching compress/decompress
> + *			operations.
>   * @reqsize:		Context size for (de)compression requests
>   * @fb:			Synchronous fallback tfm
>   * @base:		Common crypto API algorithm data structure
> @@ -115,6 +117,7 @@ struct acomp_req {
>  struct crypto_acomp {
>  	int (*compress)(struct acomp_req *req);
>  	int (*decompress)(struct acomp_req *req);
> +	unsigned int batch_size;

There is no need to store the batch_size in the tfm.  Just return
the value from acomp_alg directly.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt