linux-kernel - Re: [PATCH 2/2] reset: remove legacy reset lookup code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7cef6733507f86dfcc30131f1d941a47771a394a.camel@pengutronix.de>
Date: Fri, 17 Oct 2025 11:34:53 +0200
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Bartosz Golaszewski <brgl@...ev.pl>, David Lechner
 <david@...hnology.com>,  Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>
Cc: linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, Bartosz
 Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 2/2] reset: remove legacy reset lookup code

Hi Bartosz,

On Fr, 2025-10-17 at 10:02 +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> There are no more users of this code. Let's remove the exported symbols
> and the implementation from reset core.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> ---
>  drivers/reset/core.c             | 120 +--------------------------------------
>  include/linux/reset-controller.h |  33 -----------

Ah, the best kind of patch.

>  2 files changed, 2 insertions(+), 151 deletions(-)
> 
> diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> index 22f67fc77ae531c6efba3ce92cc73a2d57397762..9ca4ac27daf955d7fe74f7684819072a6f32492b 100644
> --- a/drivers/reset/core.c
> +++ b/drivers/reset/core.c
[...]
> @@ -1081,70 +1054,6 @@ __of_reset_control_get(struct device_node *node, const char *id, int index,
>  }
>  EXPORT_SYMBOL_GPL(__of_reset_control_get);
>  
> -static struct reset_controller_dev *
> -__reset_controller_by_name(const char *name)
> -{
> -	struct reset_controller_dev *rcdev;
> -
> -	lockdep_assert_held(&reset_list_mutex);
> -
> -	list_for_each_entry(rcdev, &reset_controller_list, list) {
> -		if (!rcdev->dev)
> -			continue;
> -
> -		if (!strcmp(name, dev_name(rcdev->dev)))
> -			return rcdev;
> -	}
> -
> -	return NULL;
> -}
> -
> -static struct reset_control *
> -__reset_control_get_from_lookup(struct device *dev, const char *con_id,
> -				enum reset_control_flags flags)
> -{
> -	bool optional = flags & RESET_CONTROL_FLAGS_BIT_OPTIONAL;
> -	const struct reset_control_lookup *lookup;
> -	struct reset_controller_dev *rcdev;
> -	const char *dev_id = dev_name(dev);
> -	struct reset_control *rstc = NULL;
> -
> -	mutex_lock(&reset_lookup_mutex);
> -
> -	list_for_each_entry(lookup, &reset_lookup_list, list) {
> -		if (strcmp(lookup->dev_id, dev_id))
> -			continue;
> -
> -		if ((!con_id && !lookup->con_id) ||
> -		    ((con_id && lookup->con_id) &&
> -		     !strcmp(con_id, lookup->con_id))) {
> -			mutex_lock(&reset_list_mutex);
> -			rcdev = __reset_controller_by_name(lookup->provider);
> -			if (!rcdev) {
> -				mutex_unlock(&reset_list_mutex);
> -				mutex_unlock(&reset_lookup_mutex);
> -				/* Reset provider may not be ready yet. */
> -				return ERR_PTR(-EPROBE_DEFER);
> -			}
> -
> -			flags &= ~RESET_CONTROL_FLAGS_BIT_OPTIONAL;
> -
> -			rstc = __reset_control_get_internal(rcdev,
> -							    lookup->index,
> -							    flags);
> -			mutex_unlock(&reset_list_mutex);
> -			break;
> -		}
> -	}
> -
> -	mutex_unlock(&reset_lookup_mutex);
> -
> -	if (!rstc)
> -		return optional ? NULL : ERR_PTR(-ENOENT);
> -
> -	return rstc;
> -}
> -
>  struct reset_control *__reset_control_get(struct device *dev, const char *id,
>  					  int index, enum reset_control_flags flags)
>  {
> @@ -1157,7 +1066,7 @@ struct reset_control *__reset_control_get(struct device *dev, const char *id,
>  	if (dev->of_node)
>  		return __of_reset_control_get(dev->of_node, id, index, flags);
>  
> -	return __reset_control_get_from_lookup(dev, id, flags);
> +	return ERR_PTR(-ENOENT);

I think this should be:

	bool optional = flags & RESET_CONTROL_FLAGS_BIT_OPTIONAL;

	/* ... */

	return optional ? NULL : ERR_PTR(-ENOENT);

With that,

Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

regards
Philipp