| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <23f08812-7890-446e-95b7-4ff5b8f547f2@linaro.org> Date: Fri, 17 Oct 2025 11:55:37 +0200 From: Neil Armstrong <neil.armstrong@...aro.org> To: Wangao Wang <wangao.wang@....qualcomm.com>, vikash.garodia@....qualcomm.com, dikshita.agarwal@....qualcomm.com, abhinav.kumar@...ux.dev, bod@...nel.org, mchehab@...nel.org Cc: linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, quic_qiweil@...cinc.com, quic_renjiang@...cinc.com Subject: Re: [PATCH v1 0/4] media: qcom: iris: encoder feature enhancements On 10/15/25 11:27, Wangao Wang wrote: > Hi All, > > This patch series introduces several enhancements to the Qualcomm Iris > encoder driver, improving support for V4L2 controls and enabling more > video encoding features. > > All patches have been tested with v4l2-compliance, v4l2-ctl and > on QCS8300 for encoder. Nice, but did you test those on any other device ? This patchset affects all supported HW, so please test on all of them. > > Commands used for V4l2-ctl validation: > > Scale: > v4l2-ctl --verbose -d /dev/video1 \ > --set-fmt-video-out=width=1920,height=1080,pixelformat=NV12 \ > --set-selection-output target=crop,width=1920,height=1080 \ > --set-fmt-video=width=1280,height=720,pixelformat=H264 \ > --stream-mmap --stream-out-mmap \ > --stream-from=input_nv12_1080p.yuv \ > --stream-to=output/scale_720p_output.h264 Please provide a way to generate/retrieve this `input_nv12_1080p.yuv` file aswell. Thanks, Neil> > Flip: > v4l2-ctl --verbose -d /dev/video1 \ > --set-fmt-video-out=width=1920,height=1080,pixelformat=NV12 \ > --set-selection-output target=crop,width=1920,height=1080 \ > --set-fmt-video=pixelformat=H264 --stream-mmap --stream-out-mmap \ > --stream-from=input_nv12_1080p.yuv \ > --stream-to=output/vertical_flip.h264 \ > --set-ctrl vertical_flip=1 > > v4l2-ctl --verbose -d /dev/video1 \ > --set-fmt-video-out=width=1920,height=1080,pixelformat=NV12 \ > --set-selection-output target=crop,width=1920,height=1080 \ > --set-fmt-video=pixelformat=H264 --stream-mmap --stream-out-mmap \ > --stream-from=input_nv12_1080p.yuv \ > --stream-to=output/horizontal_flip.h264 \ > --set-ctrl horizontal_flip=1 > > Rotate: > v4l2-ctl --verbose -d /dev/video1 \ > --set-fmt-video-out=width=1920,height=1080,pixelformat=NV12 \ > --set-selection-output target=crop,width=1920,height=1080 \ > --set-fmt-video=pixelformat=H264 --stream-mmap --stream-out-mmap \ > --stream-from=input_nv12_1080p.yuv \ > --stream-to=output/rotate90.h264 \ > --set-ctrl rotate=90 > > v4l2-ctl --verbose -d /dev/video1 \ > --set-fmt-video-out=width=1920,height=1080,pixelformat=NV12 \ > --set-selection-output target=crop,width=1920,height=1080 \ > --set-fmt-video=pixelformat=H264 --stream-mmap --stream-out-mmap \ > --stream-from=input_nv12_1080p.yuv \ > --stream-to=output/rotate180.h264 \ > --set-ctrl rotate=180 > > v4l2-ctl --verbose -d /dev/video1 \ > --set-fmt-video-out=width=1920,height=1080,pixelformat=NV12 \ > --set-selection-output target=crop,width=1920,height=1080 \ > --set-fmt-video=pixelformat=H264 --stream-mmap --stream-out-mmap \ > --stream-from=input_nv12_1080p.yuv \ > --stream-to=output/rotate270.h264 \ > --set-ctrl rotate=270 > > Intra Refresh: > Testing of this feature requires the use of this application. > https://github.com/quic/v4l-video-test-app > > The result of v4l2-compliance on QCS8300: > v4l2-compliance 1.31.0-5378, 64 bits, 64-bit time_t > v4l2-compliance SHA: 2ed8da243dd1 2025-06-30 08:18:40 > > Compliance test for iris_driver device /dev/video1: > > Driver Info: > Driver name : iris_driver > Card type : Iris Encoder > Bus info : platform:aa00000.video-codec > Driver version : 6.17.0 > Capabilities : 0x84204000 > Video Memory-to-Memory Multiplanar > Streaming > Extended Pix Format > Device Capabilities > Device Caps : 0x04204000 > Video Memory-to-Memory Multiplanar > Streaming > Extended Pix Format > Detected Stateful Encoder > > Required ioctls: > test VIDIOC_QUERYCAP: OK > test invalid ioctls: OK > > Allow for multiple opens: > test second /dev/video1 open: OK > test VIDIOC_QUERYCAP: OK > test VIDIOC_G/S_PRIORITY: OK > test for unlimited opens: OK > > Debug ioctls: > test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) > test VIDIOC_LOG_STATUS: OK (Not Supported) > > Input ioctls: > test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) > test VIDIOC_G/S_FREQUENCY: OK (Not Supported) > test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) > test VIDIOC_ENUMAUDIO: OK (Not Supported) > test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) > test VIDIOC_G/S_AUDIO: OK (Not Supported) > Inputs: 0 Audio Inputs: 0 Tuners: 0 > > Output ioctls: > test VIDIOC_G/S_MODULATOR: OK (Not Supported) > test VIDIOC_G/S_FREQUENCY: OK (Not Supported) > test VIDIOC_ENUMAUDOUT: OK (Not Supported) > test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) > test VIDIOC_G/S_AUDOUT: OK (Not Supported) > Outputs: 0 Audio Outputs: 0 Modulators: 0 > > Input/Output configuration ioctls: > test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) > test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) > test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) > test VIDIOC_G/S_EDID: OK (Not Supported) > > Control ioctls: > test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK > test VIDIOC_QUERYCTRL: OK > test VIDIOC_G/S_CTRL: OK > test VIDIOC_G/S/TRY_EXT_CTRLS: OK > test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK > test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) > Standard Controls: 43 Private Controls: 0 > > Format ioctls: > test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK > test VIDIOC_G/S_PARM: OK > test VIDIOC_G_FBUF: OK (Not Supported) > test VIDIOC_G_FMT: OK > test VIDIOC_TRY_FMT: OK > test VIDIOC_S_FMT: OK > test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) > test Cropping: OK > test Composing: OK (Not Supported) > test Scaling: OK (Not Supported) > > Codec ioctls: > test VIDIOC_(TRY_)ENCODER_CMD: OK > test VIDIOC_G_ENC_INDEX: OK (Not Supported) > test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) > > Buffer ioctls: > test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK > test CREATE_BUFS maximum buffers: OK > test VIDIOC_REMOVE_BUFS: OK > test VIDIOC_EXPBUF: OK > test Requests: OK (Not Supported) > test blocking wait: OK > > Test input 0: > > Streaming ioctls: > test read/write: OK (Not Supported) > Video Capture Multiplanar: Captured 61 buffers > test MMAP (select, REQBUFS): OK > Video Capture Multiplanar: Captured 61 buffers > test MMAP (epoll, REQBUFS): OK > Video Capture Multiplanar: Captured 61 buffers > test MMAP (select, CREATE_BUFS): OK > Video Capture Multiplanar: Captured 61 buffers > test MMAP (epoll, CREATE_BUFS): OK > test USERPTR (select): OK (Not Supported) > test DMABUF: Cannot test, specify --expbuf-device > > Total for iris_driver device /dev/video1: 54, Succeeded: 54, Failed: 0, Warnings: 0 > > Wangao Wang (4): > media: qcom: iris: Add support for scale and improve format alignment > media: qcom: iris: Add rotation support for encoder > media: qcom: iris: Add flip support for encoder > media: qcom: iris: Add intra refresh support for encoder > > drivers/media/platform/qcom/iris/iris_ctrls.c | 94 +++++++++++++++++++ > drivers/media/platform/qcom/iris/iris_ctrls.h | 3 + > .../qcom/iris/iris_hfi_gen2_command.c | 26 +++-- > .../qcom/iris/iris_hfi_gen2_defines.h | 19 ++++ > .../qcom/iris/iris_hfi_gen2_response.c | 2 + > .../media/platform/qcom/iris/iris_instance.h | 8 ++ > .../platform/qcom/iris/iris_platform_common.h | 5 + > .../platform/qcom/iris/iris_platform_gen2.c | 61 ++++++++++++ > drivers/media/platform/qcom/iris/iris_utils.c | 6 ++ > drivers/media/platform/qcom/iris/iris_utils.h | 1 + > drivers/media/platform/qcom/iris/iris_venc.c | 28 +++++- > .../platform/qcom/iris/iris_vpu_buffer.c | 52 +++++----- > 12 files changed, 273 insertions(+), 32 deletions(-) >
Powered by blists - more mailing lists