linux-kernel - Re: [REGRESSION] in 6.18-rc1, failed to query a GPIO using a name in ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPIUMoDxW-yl2nPm@sunil-laptop>
Date: Fri, 17 Oct 2025 15:32:26 +0530
From: Sunil V L <sunilvl@...tanamicro.com>
To: Thomas Richard <thomas.richard@...tlin.com>
Cc: rafael@...nel.org, regressions@...ts.linux.dev, lenb@...nel.org,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	apatel@...tanamicro.com,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	Daniele Cleri <DanieleCleri@...on.eu>
Subject: Re: [REGRESSION] in 6.18-rc1, failed to query a GPIO using a name in
 ACPI

On Fri, Oct 17, 2025 at 10:50:05AM +0200, Thomas Richard wrote:
> On 10/17/25 12:22 AM, Sunil V L wrote:
> > On Thu, Oct 16, 2025 at 02:47:40PM +0200, Thomas Richard wrote:
> >> Hello,
> >>
> >> While testing the AAEON UpBoard MFD driver with the v6.18-rc1 release, I
> >> noticed a regression. The driver does not probe anymore and I get the
> >> following error:
> >>
> >> [    1.977831] upboard-fpga AANT0F01:00: error -ENOENT: Failed to
> >> initialize FPGA common GPIOs
> >> [    1.977854] upboard-fpga AANT0F01:00: probe with driver upboard-fpga
> >> failed with error -2
> >>
> >> The driver fails to get some GPIOs using a name [1] in the ACPI tables [2].
> >>
> >> I did a bisect and I found the commit which introduced the regression:
> >> e121be784d35 ("ACPI: property: Refactor acpi_fwnode_get_reference_args()
> >> to support nargs_prop")
> >>
> > Hi Thomas,
> > 
> > Could you please try with below change and see if it resolves the issue?
> > 
> > diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
> > index 1b997a5497e7..43d5e457814e 100644
> > --- a/drivers/acpi/property.c
> > +++ b/drivers/acpi/property.c
> > @@ -1107,7 +1107,7 @@ int __acpi_node_get_property_reference(const struct fwnode_handle *fwnode,
> >                                        size_t num_args,
> >                                        struct fwnode_reference_args *args)
> >  {
> > -       return acpi_fwnode_get_reference_args(fwnode, propname, NULL, index, num_args, args);
> > +       return acpi_fwnode_get_reference_args(fwnode, propname, NULL, num_args, index, args);
> >  }
> > 
> 
> Hi Sunil,
> 
> Yes your change fixes the issue !!
> 
Hi Thomas,

Thanks for confirming the fix!

I'll send out the patch shortly and include your Tested-by tag.

Apologies for the earlier issue, and thank you for your help.

Best regards,
Sunil