linux-kernel - Re: [PATCH net-next v02 4/6] hinic3: Add mac filter ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e8b52cf3-9f77-445c-8ba6-d8ac402841b7@web.de>
Date: Fri, 17 Oct 2025 13:51:03 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Fan Gong <gongfan1@...wei.com>, Zhu Yikai <zhuyikai1@...artners.com>,
 netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Pavan Chebbi <pavan.chebbi@...adcom.com>, Simon Horman <horms@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
 Gur Stavi <gur.stavi@...wei.com>, luosifu@...wei.com,
 Luo Yang <luoyang82@...artners.com>, Meny Yossefi <meny.yossefi@...wei.com>,
 Shen Chenyang <shenchenyang1@...ilicon.com>, Shi Jing
 <shijing34@...wei.com>, Wu Like <wulike1@...wei.com>,
 Xin Guo <guoxin09@...wei.com>, Zhou Shuai <zhoushuai28@...wei.com>
Subject: Re: [PATCH net-next v02 4/6] hinic3: Add mac filter ops

…> +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_filter.c
> @@ -0,0 +1,413 @@
…> +static int hinic3_mac_filter_sync(struct net_device *netdev,
> +				  struct list_head *mac_filter_list, bool uc)
> +{
…
> +		hinic3_cleanup_filter_list(&tmp_add_list);> +		hinic3_mac_filter_sync_hw(netdev, &tmp_del_list, &tmp_add_list);
> +
> +		/* need to enter promiscuous/allmulti mode */
> +		err = -ENOMEM;
> +		goto err_out;
> +	}
> +
> +	return add_count;
> +
> +err_out:
> +	return err;
> +}

Is there a need to move any resource cleanup actions behind a more appropriate label?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.17#n532

Regards,
Markus