linux-kernel - Re: [PATCH v14 8/9] platform/x86: asus-wmi: rename ASUS_WMI_DEVID_PPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22ecdffb-d92c-3a71-6869-3b74f7db67fe@linux.intel.com>
Date: Fri, 17 Oct 2025 15:59:07 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Denis Benato <benato.denis96@...il.com>
cc: LKML <linux-kernel@...r.kernel.org>, platform-driver-x86@...r.kernel.org, 
    Hans de Goede <hdegoede@...hat.com>, 
    "Limonciello, Mario" <mario.limonciello@....com>, 
    "Luke D . Jones" <luke@...nes.dev>, Alok Tiwari <alok.a.tiwari@...cle.com>, 
    Derek John Clark <derekjohn.clark@...il.com>, 
    Mateusz Schyboll <dragonn@...pl>, porfet828@...il.com
Subject: Re: [PATCH v14 8/9] platform/x86: asus-wmi: rename
 ASUS_WMI_DEVID_PPT_FPPT

On Wed, 15 Oct 2025, Denis Benato wrote:

> As pointed out in [1], in order to maintain a naming consistency with

Please rephrase without that part before comma. That is, just state what 
this change does, the Link tag will be there for those who want to read 
extra details about how it came to be.

> ASUS_WMI_DEVID_PPT_PL2_SPPT and ASUS_WMI_DEVID_PPT_PL1_SPL
> rename ASUS_WMI_DEVID_PPT_FPPT to ASUS_WMI_DEVID_PPT_PL3_FPPT.
> 
> [1] https://lore.kernel.org/all/cad7b458-5a7a-4975-94a1-d0c74f6f3de5@oracle.com/

Please change to:

Link: https://.../

You may want to also add:

Suggested-by: ALOK TIWARI <alok.a.tiwari@...cle.com>

> Signed-off-by: Denis Benato <benato.denis96@...il.com>
> ---
>  drivers/platform/x86/asus-wmi.c            | 4 ++--
>  include/linux/platform_data/x86/asus-wmi.h | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 3727ae00133d..8b5ac4636623 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -1211,7 +1211,7 @@ static ssize_t ppt_fppt_store(struct device *dev,
>  	if (value < PPT_TOTAL_MIN || value > PPT_TOTAL_MAX)
>  		return -EINVAL;
>  
> -	err = asus_wmi_set_devstate(ASUS_WMI_DEVID_PPT_FPPT, value, &result);
> +	err = asus_wmi_set_devstate(ASUS_WMI_DEVID_PPT_PL3_FPPT, value, &result);
>  	if (err) {
>  		pr_warn("Failed to set ppt_fppt: %d\n", err);
>  		return err;
> @@ -4595,7 +4595,7 @@ static umode_t asus_sysfs_is_visible(struct kobject *kobj,
>  	else if (attr == &dev_attr_ppt_pl1_spl.attr)
>  		devid = ASUS_WMI_DEVID_PPT_PL1_SPL;
>  	else if (attr == &dev_attr_ppt_fppt.attr)
> -		devid = ASUS_WMI_DEVID_PPT_FPPT;
> +		devid = ASUS_WMI_DEVID_PPT_PL3_FPPT;
>  	else if (attr == &dev_attr_ppt_apu_sppt.attr)
>  		devid = ASUS_WMI_DEVID_PPT_APU_SPPT;
>  	else if (attr == &dev_attr_ppt_platform_sppt.attr)
> diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/platform_data/x86/asus-wmi.h
> index 260796fee301..3d236f8498d8 100644
> --- a/include/linux/platform_data/x86/asus-wmi.h
> +++ b/include/linux/platform_data/x86/asus-wmi.h
> @@ -108,7 +108,7 @@
>  #define ASUS_WMI_DEVID_PPT_PL1_SPL		0x001200A3
>  #define ASUS_WMI_DEVID_PPT_APU_SPPT		0x001200B0
>  #define ASUS_WMI_DEVID_PPT_PLAT_SPPT	0x001200B1
> -#define ASUS_WMI_DEVID_PPT_FPPT			0x001200C1
> +#define ASUS_WMI_DEVID_PPT_PL3_FPPT		0x001200C1
>  #define ASUS_WMI_DEVID_NV_DYN_BOOST		0x001200C0
>  #define ASUS_WMI_DEVID_NV_THERM_TARGET	0x001200C2
>  
> 

-- 
 i.