linux-kernel - Re: [PATCH 00/29] drm: Implement state readout support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPJAnPWneXod2REH@phenom.ffwll.local>
Date: Fri, 17 Oct 2025 15:11:56 +0200
From: Simona Vetter <simona.vetter@...ll.ch>
To: Maxime Ripard <mripard@...nel.org>
Cc: Thomas Zimmermann <tzimmermann@...e.de>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Andrzej Hajda <andrzej.hajda@...el.com>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Robert Foss <rfoss@...nel.org>,
	Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
	Jonas Karlman <jonas@...boo.se>,
	Jernej Skrabec <jernej.skrabec@...il.com>,
	Jyri Sarha <jyri.sarha@....fi>,
	Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
	Devarsh Thakkar <devarsht@...com>, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/29] drm: Implement state readout support

On Tue, Sep 23, 2025 at 11:15:55AM +0200, Maxime Ripard wrote:
> Hi Thomas,
> 
> On Tue, Sep 02, 2025 at 04:13:21PM +0200, Thomas Zimmermann wrote:
> > Hi Maxime,
> > 
> > there are a number of patches in this series that can be merged immediately,
> > and likely should.
> 
> Ack, I'll do a first pass to apply the preliminary patches if (or when)
> they get reviewed.
> 
> > Is the state-compare code really necessary? Doing this separately might ease
> > the review.
> 
> My understanding was that Sima wanted to be part of it, but I guess we
> can introduce it later on if she agrees.

Yeah I think without readout state comparison fastboot is nigh impossible
to validate and keep working. For merging splitting things sounds fine,
but for enabling in production I'd be very vary to ship this without.

I think a module option for developers and testing would be good here to
make this happen: -1/default means you only get fastboot when the entire
driver (including all bridges) support both state readout and comparison,
and then you can override that with 0/1. And this should be a tainting
module option I think.
-Sima
-- 
Simona Vetter
Software Engineer
http://blog.ffwll.ch