linux-kernel - Re: [PATCH v6 01/10] x86/acpi: Add helper functions to setup and access the wakeup mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251017211015.GA7078@ranerica-svr.sc.intel.com>
Date: Fri, 17 Oct 2025 14:10:15 -0700
From: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: x86@...nel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Rob Herring <robh@...nel.org>,
	"K. Y. Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
	Michael Kelley <mhklinux@...look.com>,
	Saurabh Sengar <ssengar@...ux.microsoft.com>,
	Chris Oo <cho@...rosoft.com>, "Kirill A. Shutemov" <kas@...nel.org>,
	linux-hyperv@...r.kernel.org, devicetree@...r.kernel.org,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Ricardo Neri <ricardo.neri@...el.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
Subject: Re: [PATCH v6 01/10] x86/acpi: Add helper functions to setup and
 access the wakeup mailbox

On Fri, Oct 17, 2025 at 11:46:59AM +0200, Rafael J. Wysocki wrote:
> On Fri, Oct 17, 2025 at 4:48 AM Ricardo Neri
> <ricardo.neri-calderon@...ux.intel.com> wrote:
> >
> > In preparation to move the functionality to wake secondary CPUs up from the
> > ACPI code, add two helper functions.
> >
> > The function acpi_setup_mp_wakeup_mailbox() stores the physical address of
> > the mailbox and updates the wakeup_secondary_cpu_64() APIC callback.
> >
> > There is a slight change in behavior: now the APIC callback is updated
> > before configuring CPU hotplug offline behavior. This is fine as the APIC
> > callback continues to be updated unconditionally, regardless of the
> > restriction on CPU offlining.
> >
> > The function acpi_madt_multiproc_wakeup_mailbox() returns a pointer to the
> > mailbox. Use this helper function only in the portions of the code for
> > which the variable acpi_mp_wake_mailbox will be out of scope once it is
> > relocated out of the ACPI directory.
> >
> > The wakeup mailbox is only supported for CONFIG_X86_64 and needed only with
> > CONFIG_SMP=y.
> >
> > Reviewed-by: Dexuan Cui <decui@...rosoft.com>
> > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> This should have been
> 
> Acked-by: Rafael J. Wysocki (Intel) <rafael.j.wysocki@...el.com>
> 
> The "(Intel)" part is missing and I omitted it when I sent the tag.
> Sorry for the confusion.

Thanks for the clarification Rafael. Does this clarification apply also
patches 2 and 3?

Also, if no further changes are needed in the series, can it be corrected
when the patches are merged?