linux-kernel - Re: [PATCH] PCI: rockchip: Propagate dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a369c5a-1558-4c50-88b5-028a1c9cc359@web.de>
Date: Sat, 18 Oct 2025 09:15:29 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Anand Moon <linux.amoon@...il.com>, linux-pci@...r.kernel.org,
 linux-rockchip@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 Bjorn Helgaas <bhelgaas@...gle.com>, Heiko Stübner
 <heiko@...ech.de>, Krzysztof Wilczyński
 <kwilczynski@...nel.org>, Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Manivannan Sadhasivam <mani@...nel.org>, Rob Herring <robh@...nel.org>,
 Shawn Lin <shawn.lin@...k-chips.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PCI: rockchip: Propagate dev_err_probe return value

…
> +++ b/drivers/pci/controller/pcie-rockchip.c
> @@ -134,7 +134,7 @@ int rockchip_pcie_init_port(struct rockchip_pcie *rockchip)
>  	err = reset_control_bulk_assert(ROCKCHIP_NUM_CORE_RSTS,
>  					rockchip->core_rsts);
>  	if (err) {
> -		dev_err_probe(dev, err, "Couldn't assert Core resets\n");
> +		err = dev_err_probe(dev, err, "Couldn't assert Core resets\n");
>  		goto err_exit_phy;
>  	}

I find such a variable reassignment not helpful here.
Do you really miss an error code propagation?

Regards,
Markus