linux-kernel - [PATCH] gpio: pca953x: clarify log messages about auto increment feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20251018101404.3630905-1-mail@mroth.net>
Date: Sat, 18 Oct 2025 12:14:04 +0200
From: Michael Roth <mail@...th.net>
To: linus.walleij@...aro.org
Cc: brgl@...ev.pl,
	linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Michael Roth <mail@...th.net>
Subject: [PATCH] gpio: pca953x: clarify log messages about auto increment feature

The probe messages currently print "using AI" and "using no AI",
which can be confusing to users unfamiliar with the datasheet term.

Clarify these by spelling out "auto increment", which is the meaning
of the AI bit described in the register map.

No functional change, only clearer log wording and matching comment
update.

Signed-off-by: Michael Roth <mail@...th.net>
---
 drivers/gpio/gpio-pca953x.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index b46927f55..360c14f69 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -306,7 +306,7 @@ static inline u8 pca953x_get_bit_mask(struct pca953x_chip *chip, unsigned int of
  *     Interrupt mask register		0x40 + 5 * bank_size	RW
  *     Interrupt status register	0x40 + 6 * bank_size	R
  *
- * - Registers with bit 0x80 set, the AI bit
+ * - Registers with bit 0x80 set, the AI bit (auto increment)
  *   The bit is cleared and the registers fall into one of the
  *   categories above.
  */
@@ -1203,10 +1203,10 @@ static int pca953x_probe(struct i2c_client *client)
 	pca953x_setup_gpio(chip, chip->driver_data & PCA_GPIO_MASK);
 
 	if (NBANK(chip) > 2 || PCA_CHIP_TYPE(chip->driver_data) == PCA957X_TYPE) {
-		dev_info(dev, "using AI\n");
+		dev_info(dev, "using auto increment\n");
 		regmap_config = &pca953x_ai_i2c_regmap;
 	} else {
-		dev_info(dev, "using no AI\n");
+		dev_info(dev, "using no auto increment\n");
 		regmap_config = &pca953x_i2c_regmap;
 	}
 
-- 
2.34.1