linux-kernel - Re: [GIT PULL] TPM DEVICE DRIVER: tpmdd-next-v6.18-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPOCzO_kDRojN4wi@kernel.org>
Date: Sat, 18 Oct 2025 15:06:36 +0300
From: Jarkko Sakkinen <jarkko@...nel.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Huewe <peterhuewe@....de>, Jason Gunthorpe <jgg@...pe.ca>,
	David Howells <dhowells@...hat.com>, keyrings@...r.kernel.org,
	linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
	Stuart Yoder <stuart.yoder@....com>
Subject: Re: [GIT PULL] TPM DEVICE DRIVER: tpmdd-next-v6.18-rc2

On Sat, Oct 18, 2025 at 03:03:39PM +0300, Jarkko Sakkinen wrote:
> The following changes since commit f406055cb18c6e299c4a783fc1effeb16be41803:
> 
>   Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux (2025-10-17 13:04:21 -1000)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git tags/tpmdd-next-v6.18-rc2
> 
> for you to fetch changes up to dbfdaeb381a49a7bc753d18e2876bc56a15e01cc:
> 
>   tpm_crb: Add idle support for the Arm FF-A start method (2025-10-18 14:33:22 +0300)
> 
> ----------------------------------------------------------------
> Hi,
> 
> If possible, could you still pick this change for v6.18 [1]? The change in
> question  corrects the state transitions for ARM FF-A to match the spec and
> how tpm_crb behaves on other platforms.
> 
> [1] https://lore.kernel.org/linux-integrity/aPN59bwcUrieMACf@kernel.org/
> 
> BR, Jarkko
> 
> ----------------------------------------------------------------
> Stuart Yoder (1):
>       tpm_crb: Add idle support for the Arm FF-A start method
> 
>  drivers/char/tpm/tpm_crb.c | 29 ++++++++++++++++++++---------
>  1 file changed, 20 insertions(+), 9 deletions(-)

I don't have the specific hardware to test this but I did a quick
compilation test:

make CROSS_COMPILE=aarch64-linux-gnu- ARCH=arm64 tinyconfig && ./scripts/config --file .config -e CONFIG_KEYS -e CONFIG_TCG_TPM -e CONFIG_64BIT -e CONFIG_TRUSTED_KEYS -e CONFIG_TTY -e CONFIG_PROCFS -e CONFIG_SYSFS -e CONFIG_TCG_VTPM_PROXY -e CONFIG_EFI -e CONFIG_ACPI -e CONFIG_ARM_FFA_TRANSPORT -e CONFIG_TCG_CRB && yes '' | make CROSS_COMPILE=aarch64-linux-gnu- ARCH=arm64 oldconfig && make CROSS_COMPILE=aarch64-linux-gnu- ARCH=arm64 -j$(nproc)

And in addition with similar features x86 compilation test and run
my smoke tests with swtpm emulating tpm_crb (kselftest, keyring,
trusted keys type of stuff automated).

Those should localize any possible corrateral damage to only FFA,
if any (and not very likely).

BR, Jarkko