| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20251018000713.677779-21-vipinsh@google.com>
Date: Fri, 17 Oct 2025 17:07:12 -0700
From: Vipin Sharma <vipinsh@...gle.com>
To: bhelgaas@...gle.com, alex.williamson@...hat.com, pasha.tatashin@...een.com,
dmatlack@...gle.com, jgg@...pe.ca, graf@...zon.com
Cc: pratyush@...nel.org, gregkh@...uxfoundation.org, chrisl@...nel.org,
rppt@...nel.org, skhawaja@...gle.com, parav@...dia.com, saeedm@...dia.com,
kevin.tian@...el.com, jrhilke@...gle.com, david@...hat.com,
jgowans@...zon.com, dwmw2@...radead.org, epetron@...zon.de,
junaids@...gle.com, linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
kvm@...r.kernel.org, linux-kselftest@...r.kernel.org,
Vipin Sharma <vipinsh@...gle.com>
Subject: [RFC PATCH 20/21] vfio: selftests: Add VFIO live update test
Write a test to exercise VFIO live update support on the passed device
BDF. Provide different behavior of the test based on host live update
state (NORMAL or UPDATED).
When test is executed in NORMAL state, initialize a VFIO PCI device and
enable its Bus Master Enable bit by writing to PCI command register.
Create a live update session, and pass the VFIO device FD to it for
preservation. Preserve the session and then send the global live update
prepare event. If everything is fine up to this point, then reboot the
kernel using kexec.
When test is executed in UPDATED state, retrieve the session from Live
Update Orchestrator, restore the VFIO FD from the session. Use the
restored FD to initialize vfio_pci_device in selftest. Move the host to
NORMAL state and verify if the Bus Master Enable bit is still enabled on
the VFIO device.
Test will not be auto run, therefore, only build this test and let the
user run the test manually with the command:
./run.sh -d 0000:6a:01.0 ./vfio_pci_liveupdate_test
Signed-off-by: Vipin Sharma <vipinsh@...gle.com>
---
tools/testing/selftests/vfio/Makefile | 1 +
.../selftests/vfio/vfio_pci_liveupdate_test.c | 106 ++++++++++++++++++
2 files changed, 107 insertions(+)
create mode 100644 tools/testing/selftests/vfio/vfio_pci_liveupdate_test.c
diff --git a/tools/testing/selftests/vfio/Makefile b/tools/testing/selftests/vfio/Makefile
index c7f271884cb4..949b7fcc091e 100644
--- a/tools/testing/selftests/vfio/Makefile
+++ b/tools/testing/selftests/vfio/Makefile
@@ -3,6 +3,7 @@ TEST_GEN_PROGS += vfio_dma_mapping_test
TEST_GEN_PROGS += vfio_iommufd_setup_test
TEST_GEN_PROGS += vfio_pci_device_test
TEST_GEN_PROGS += vfio_pci_driver_test
+TEST_GEN_PROGS_EXTENDED += vfio_pci_liveupdate_test
TEST_PROGS_EXTENDED := run.sh
include ../lib.mk
include lib/libvfio.mk
diff --git a/tools/testing/selftests/vfio/vfio_pci_liveupdate_test.c b/tools/testing/selftests/vfio/vfio_pci_liveupdate_test.c
new file mode 100644
index 000000000000..9fd0061348e0
--- /dev/null
+++ b/tools/testing/selftests/vfio/vfio_pci_liveupdate_test.c
@@ -0,0 +1,106 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+/*
+ * Copyright (c) 2025, Google LLC.
+ * Vipin Sharma <vipinsh@...gle.com>
+ */
+
+#include <linux/liveupdate.h>
+#include <liveupdate_util.h>
+#include <vfio_util.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <unistd.h>
+#include <sys/ioctl.h>
+
+#define SESSION_NAME "multi_file_session"
+#define TOKEN 1234
+
+static void run_pre_kexec(int luo_fd, const char *bdf)
+{
+ struct vfio_pci_device *device;
+ int session_fd;
+ u16 command;
+
+ device = vfio_pci_device_init(bdf, "iommufd");
+
+ command = vfio_pci_config_readw(device, PCI_COMMAND);
+ VFIO_ASSERT_FALSE(command & PCI_COMMAND_MASTER);
+
+ vfio_pci_config_writew(device, PCI_COMMAND,
+ command | PCI_COMMAND_MASTER);
+
+ session_fd = luo_create_session(luo_fd, SESSION_NAME);
+ VFIO_ASSERT_GE(session_fd, 0, "Failed to create session %s",
+ SESSION_NAME);
+ VFIO_ASSERT_EQ(luo_session_preserve_fd(session_fd, device->fd, TOKEN),
+ 0, "Failed to preserve VFIO device");
+ VFIO_ASSERT_EQ(luo_set_global_event(luo_fd, LIVEUPDATE_PREPARE), 0,
+ "Failed to set global PREPARE event");
+
+ VFIO_ASSERT_EQ(system(KEXEC_SCRIPT), 0, "kexec script failed");
+
+ sleep(10); /* Should not be reached */
+ vfio_pci_device_cleanup(device);
+ exit(EXIT_FAILURE);
+}
+
+static void run_post_kexec(int luo_fd, const char *bdf)
+{
+ int session_fd;
+ int vfio_fd;
+ struct vfio_pci_device *device;
+ u16 command;
+
+
+ session_fd = luo_retrieve_session(luo_fd, SESSION_NAME);
+ VFIO_ASSERT_GE(session_fd, 0, "Failed to retrieve session %s",
+ SESSION_NAME);
+
+ vfio_fd = luo_session_restore_fd(session_fd, TOKEN);
+ if (vfio_fd < 0) {
+ printf("Failed to restore VFIO device, error %d", vfio_fd);
+ exit(1);
+ }
+
+ device = vfio_pci_device_init_fd(vfio_fd);
+
+ if (luo_set_global_event(luo_fd, LIVEUPDATE_FINISH) < 0) {
+ printf("Failed to set global FINISH event");
+ exit(1);
+ }
+
+ close(session_fd);
+
+ command = vfio_pci_config_readw(device, PCI_COMMAND);
+ VFIO_ASSERT_TRUE(command & PCI_COMMAND_MASTER);
+ vfio_pci_device_cleanup(device);
+}
+
+int main(int argc, char *argv[])
+{
+ enum liveupdate_state state;
+ const char *device_bdf;
+ int luo_fd;
+
+ device_bdf = vfio_selftests_get_bdf(&argc, argv);
+
+ luo_fd = luo_open_device();
+ VFIO_ASSERT_GE(luo_fd, 0, "Failed to open %s", LUO_DEVICE);
+ VFIO_ASSERT_EQ(luo_get_global_state(luo_fd, &state), 0, "Failed to get LUO state.");
+
+ switch (state) {
+ case LIVEUPDATE_STATE_NORMAL:
+ printf("Running pre-kexec actions.\n");
+ run_pre_kexec(luo_fd, device_bdf);
+ break;
+ case LIVEUPDATE_STATE_UPDATED:
+ printf("Running post-kexec actions.\n");
+ run_post_kexec(luo_fd, device_bdf);
+ break;
+ default:
+ printf("Test started in an unexpected state: %d", state);
+ }
+
+ close(luo_fd);
+}
--
2.51.0.858.gf9c4a03a3a-goog
Powered by blists - more mailing lists