linux-kernel - Re: [REGRESSION] ath10k fails initialization, bisected to "wifi: ath10k: avoid unnecessary wait for service ready message"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <10919281648e306fd3f6713437b4793c50bb6692.camel@gmail.com>
Date: Sat, 18 Oct 2025 15:50:57 +0200
From: Klaus Kudielka <klaus.kudielka@...il.com>
To: Jeff Johnson <jeff.johnson@....qualcomm.com>, Jeff Johnson
	 <jjohnson@...nel.org>, Kalle Valo <kvalo@...nel.org>, Baochen Qiang
	 <quic_bqiang@...cinc.com>, Baochen Qiang <baochen.qiang@....qualcomm.com>
Cc: linux-wireless@...r.kernel.org, ath10k@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, Paul Menzel <pmenzel@...gen.mpg.de>, 
	regressions@...ts.linux.dev
Subject: Re: [REGRESSION] ath10k fails initialization, bisected to "wifi:
 ath10k: avoid unnecessary wait for service ready message"

On Fri, 2025-10-17 at 08:57 -0700, Jeff Johnson wrote:
> On 10/17/2025 8:37 AM, Klaus Kudielka wrote:
> > Unfortunately, this particular commit completely breaks the ath10k driver in my setup.
> > 
> > 
> > Hardware:
> > - Turris Omnia (arch/arm/boot/dts/marvell/armada-385-turris-omnia.dts)
> > - Wifi card (output from lspci): Network controller: Qualcomm Atheros QCA986x/988x 802.11ac Wireless Network Adapter
> 
> This issue was previously reported with that particular chipset.
> This is currently being tracked at:
> https://bugzilla.kernel.org/show_bug.cgi?id=220671
> 
> It may be useful to supply your information as a separate record to that bug.
> 
> /jeff

Some more observations on that topic with the hardware shown above.

ath10k_core_start() calls ath10k_wmi_wait_for_service_ready(), and later ath10k_wmi_wait_for_unified_ready().

The now *unconditional* call to ath10k_hif_send_complete_check() inside ath10k_wmi_wait_for_service_ready()
makes the later call to ath10k_wmi_wait_for_unified_ready() fail.

If I call and handle wait_for_completion_timeout() first (as it was before the patch),
ath10k_hif_send_complete_check() is *not* called, and both ath10k_wmi_wait_for_service_ready() and
ath10k_wmi_wait_for_unified_ready() succeed. Everything is back to normal.

Side note:
ath10k_wmi_wait_for_service_ready() succeeds in both cases with time_left == WMI_SERVICE_READY_TIMEOUT_HZ.

#regzbot monitor: https://bugzilla.kernel.org/show_bug.cgi?id=220671