Message-ID: <20251018162113.002d92f7@jic23-huawei>
Date: Sat, 18 Oct 2025 16:21:13 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Jorge Marques <jorge.marques@...log.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich
 <Michael.Hennerich@...log.com>, David Lechner <dlechner@...libre.com>, Nuno
 Sá <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jonathan Corbet <corbet@....net>,
 <linux-iio@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <linux-doc@...r.kernel.org>
Subject: Re: [PATCH 2/7] docs: iio: New docs for ad4062 driver

On Mon, 13 Oct 2025 09:28:00 +0200
Jorge Marques <jorge.marques@...log.com> wrote:

> This adds a new page to document how to use the ad4062 ADC driver.
> 
> Signed-off-by: Jorge Marques <jorge.marques@...log.com>
Hi Jorge,

Various comments inline.

Thanks,

Jonathan

> ---
>  Documentation/iio/ad4062.rst | 89 ++++++++++++++++++++++++++++++++++++++++++++
>  MAINTAINERS                  |  1 +
>  2 files changed, 90 insertions(+)
> 
> diff --git a/Documentation/iio/ad4062.rst b/Documentation/iio/ad4062.rst
> new file mode 100644
> index 0000000000000000000000000000000000000000..b486d7fe1916d2963c94581be3696cf58d51ca48
> --- /dev/null
> +++ b/Documentation/iio/ad4062.rst
> @@ -0,0 +1,89 @@
> +.. SPDX-License-Identifier: GPL-2.0-only
> +
> +=============
> +AD4062 driver
> +=============
> +
> +ADC driver for Analog Devices Inc. AD4060/AD4062 devices. The module name is
> +``ad4062``.
> +
> +Supported devices
> +=================
> +
> +The following chips are supported by this driver:
> +
> +* `AD4060 <https://www.analog.com/AD4060>`_
> +* `AD4062 <https://www.analog.com/AD4062>`_
> +
> +Wiring modes
> +============
> +
> +The ADC is interfaced through an I3C bus, and contains two programmable GPIOs.
This raises a question on whether it makes sense for the binding to support providing
gpios from the start (as alternative to interrupts).  Seems like the two pins
are completely interchangeable so one might well be 'left' for use by some other
device that needs a gpio pin.

I don't mind that much if we want to leave the binding support for that for later
but in the ideal case we'd have it from the start (even if the driver doesn't
support it until we have a user).

> +
> +The ADC convert-start happens on the SDA rising edge of the I3C stop (P) bit
> +at the end of the read command.
> +
> +The two programmable GPIOS are optional and have a role assigned if present in
> +the devicetree:
> +
> +- GP1: Is assigned the role of Data Ready signal.

I assume that's only the case if GP1 is provided?  If GP0 is the only one
we should allow use that for data ready.  As long as the DT allows that it is
permissible for the driver to not do so for now.

> +
> +Device attributes
> +=================
> +
> +The ADC contains only one channel with following attributes:
> +
> +.. list-table:: Channel attributes
> +   :header-rows: 1
> +
> +   * - Attribute
> +     - Description
> +   * - ``in_voltage_calibscale``
> +     - Sets the scale factor to multiply the raw value.
That's confusing.  This should be hardware 'tweak' to compensate for
calibration or similar.  The text doesn't make it clear where that multiply
is happening. Sounds too much like _scale.

> +   * - ``in_voltage_oversampling_ratio``
> +     - Sets device's burst averaging mode to over sample using the
> +       internal sample rate. Value 1 disable the burst averaging mode.
> +   * - ``in_voltage_oversampling_ratio_available``
> +     - List of available oversampling values.
> +   * - ``in_voltage_raw``
> +     - Returns the raw ADC voltage value.
> +   * - ``in_voltage_scale``
> +     - Returs the channel scale in reference to the reference voltage

Spell check needed.  Also this describes why it might take different values
but not the bit users care about which is the standard ABI thing of
Real value in mV = _raw * _scale 

> +       ``ref-supply``.
> +
> +Also contain the following device attributes:
> +
> +.. list-table:: Device attributes
> +   :header-rows: 1
> +
> +   * - Attribute
> +     - Description
> +   * - ``samling_frequency``

Check these.. sampling_frequency.

> +     - Sets the sets the device internal sample rate, used in the burst
> +       averaging mode.

It's not use otherwise?  That's unusual ABI.  I'd expect it to give
the right value at least when burst mode isn't used. Or is burst mode
the only way we do buffered capture?

> +   * - ``sampling_frequency_available``
> +     - Lists the available device internal sample rates.
> +
> +Interrupts
> +==========
> +
> +The interrupts are mapped through the ``interrupt-names`` and ``interrupts``
> +properties.
> +
> +The ``interrupt-names`` ``gp1`` entry sets the role of Data Ready signal.
> +If it is not present, the driver fallback to enabling the same role as an
> +I3C IBI.

It feels like it should be easy to use the other GPO pin in this case if that
is present. 

> +
> +Low-power mode
> +==============
> +
> +The device enters low-power mode on idle to save power. Enabling an event puts
> +the device out of the low-power since the ADC autonomously samples to assert
> +the event condition.
> +
> +Unimplemented features
> +======================
> +
> +- Monitor mode
> +- Trigger mode
> +- Averaging mode
> diff --git a/MAINTAINERS b/MAINTAINERS
> index afbfaeba5387b9fbfa9bf1443a059c47dd596d45..ce012c6c719023d3c0355676a335a55d92cf424c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1405,6 +1405,7 @@ M:	Jorge Marques <jorge.marques@...log.com>
>  S:	Supported
>  W:	https://ez.analog.com/linux-software-drivers
>  F:	Documentation/devicetree/bindings/iio/adc/adi,ad4062.yaml
> +F:	Documentation/iio/ad4062.rst
>  
>  ANALOG DEVICES INC AD4080 DRIVER
>  M:	Antoniu Miclaus <antoniu.miclaus@...log.com>
> 

Powered by blists - more mailing lists