linux-kernel - Re: [PATCH v2] dt-bindings: watchdog: lantiq,wdt: convert bindings to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6215c723-aeb2-4ef5-940a-a70806c1576f@kernel.org>
Date: Sat, 18 Oct 2025 17:48:02 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Aleksander Jan Bajkowski <olek2@...pl>, wim@...ux-watchdog.org,
 linux@...ck-us.net, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, hauke@...ke-m.de, linux-watchdog@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: watchdog: lantiq,wdt: convert bindings to
 dtschema

On 18/10/2025 11:29, Aleksander Jan Bajkowski wrote:
> Convert the Lantiq WDT Watchdog bindings to yaml format.
> 
> Signed-off-by: Aleksander Jan Bajkowski <olek2@...pl>
> ---
> v2:
> - requirement of lantiq,rcu is now expressed as a schema 
> ---
>  .../bindings/watchdog/lantiq,wdt.yaml         | 63 +++++++++++++++++++
>  .../bindings/watchdog/lantiq-wdt.txt          | 24 -------
>  2 files changed, 63 insertions(+), 24 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/lantiq,wdt.yaml
>  delete mode 100644 Documentation/devicetree/bindings/watchdog/lantiq-wdt.txt
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/lantiq,wdt.yaml b/Documentation/devicetree/bindings/watchdog/lantiq,wdt.yaml
> new file mode 100644
> index 000000000000..204e16be2a79
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/lantiq,wdt.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/lantiq,wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Lantiq WTD watchdog
> +
> +maintainers:
> +  - Hauke Mehrtens <hauke@...ke-m.de>
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - enum:
> +          - lantiq,falcon-wdt
> +          - lantiq,wdt
> +          - lantiq,xrx100-wdt
> +      - items:
> +          - enum:
> +              - lantiq,xrx200-wdt
> +              - lantiq,xrx300-wdt


This wasn't in the old binding. Any change from pure conversion has to
be explained WHY in the commit msg.

What is more - it does not exist. You cannot just stuff here new
compatibles and call it "conversion". Conversion from dev/null into new
compatible?

> +          - const: lantiq,xrx100-wdt
> +
> +  reg:
> +    maxItems: 1
> +
> +  lantiq,rcu:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: Phandle to the RCU syscon node
> +
> +required:
> +  - compatible
> +  - reg
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: lantiq,xrx100-wdt
> +    then:
> +      required:
> +        - lantiq,rcu
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: lantiq,falcon-wdt


That's just enum in previous contains.

> +    then:
> +      required:
> +        - lantiq,rcu


Missing ref to watchdog. Otherwise why do you have unevaluatedProperties?
> +
> +unevaluatedProperties: false




Best regards,
Krzysztof