linux-kernel - Re: [PATCH] PCI/pwrctrl: Propagate dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <03a8fd58-cce5-4b84-adef-6cec235c582b@web.de>
Date: Sat, 18 Oct 2025 18:05:36 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Christophe Jaillet <christophe.jaillet@...adoo.fr>,
 linux-pci@...r.kernel.org, Anand Moon <linux.amoon@...il.com>,
 Bartosz Golaszewski <brgl@...ev.pl>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Marek Vasut <marek.vasut+renesas@...lbox.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PCI/pwrctrl: Propagate dev_err_probe return value

> >   	slot->num_supplies = ret;
> >   	ret = regulator_bulk_enable(slot->num_supplies, slot->supplies);
> >   	if (ret < 0) {
> > -		dev_err_probe(dev, ret, "Failed to enable slot regulators\n");
> > +		ret = dev_err_probe(dev, ret, "Failed to enable slot regulators\n");
> >   		regulator_bulk_free(slot->num_supplies, slot->supplies);
> >   		return ret;
> 
> Doing:
>     		regulator_bulk_free(slot->num_supplies, slot->supplies);
>     		return dev_err_probe(dev, ret, "Failed to enable slot regulators\n");
> 
> Would be more consistent.

How does this view fit to the commit ab81f2f79c683c94bac622aafafbe8232e547159
("PCI/pwrctrl: Fix double cleanup on devm_add_action_or_reset() failure")
from 2025-08-13?

Regards,
Markus