linux-kernel - Re: [PATCH v11 1/2] dt-bindings: memory: mediatek: Add SMI reset and clamp for MT8188

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5e3a0317-31b2-43f1-9a4b-b66447a6044d@kernel.org>
Date: Sat, 18 Oct 2025 18:42:49 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Friday Yang <friday.yang@...iatek.com>, Yong Wu <yong.wu@...iatek.com>,
 Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Philipp Zabel <p.zabel@...gutronix.de>
Cc: linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH v11 1/2] dt-bindings: memory: mediatek: Add SMI reset and
 clamp for MT8188

On 17/09/2025 14:07, Friday Yang wrote:
> Add 'resets' and 'reset-names' properties for SMI LARBs to support
> SMI reset operations.

Not informative...

> diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
> index 2e7fac4b5094..fc5feb2eac1f 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
> @@ -70,6 +70,12 @@ properties:
>      description: the hardware id of this larb. It's only required when this
>        hardware id is not consecutive from its M4U point of view.
> 
> +  resets:
> +    maxItems: 1
> +
> +  reset-names:
> +    const: larb

Is the reset valid for all existing devices as well? Commit msg does not
explain that... it is pretty useless - you say what you did. We see that
from the diff. Explain something not obvious.



Best regards,
Krzysztof