linux-kernel - Re: [PATCH] serial: 8250_dw: handle reset control deassert error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aO_NYGFCKb0J2uqK@smile.fi.intel.com>
Date: Wed, 15 Oct 2025 19:35:44 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Artem Shimko <a.shimko.dev@...il.com>
Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jirislaby@...nel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH] serial: 8250_dw: handle reset control deassert error

On Thu, Oct 09, 2025 at 11:13:08AM +0300, Artem Shimko wrote:
> Check the return value of reset_control_deassert() in the probe
> function to prevent continuing probe when reset deassertion fails.
> 
> Previously, reset_control_deassert() was called without checking its
> return value, which could lead to probe continuing even when the
> device reset wasn't properly deasserted.
> 
> The fix checks the return value and returns an error with dev_err_probe()
> if reset deassertion fails, providing better error handling and
> diagnostics.

If it's not applied yet, it deserves the Fixes tag, I believe.

-- 
With Best Regards,
Andy Shevchenko