linux-kernel - Re: [PATCH v7 3/3] i2c: pcf8584: Move 'ret' variable inside for loop, break if ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5e4c7964-0b15-4595-ba14-bbc0c71520fd@web.de>
Date: Sat, 18 Oct 2025 20:00:31 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Cezar Chiru <chiru.cezar.89@...il.com>, linux-i2c@...r.kernel.org,
 Andi Shyti <andi.shyti@...nel.org>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 3/3] i2c: pcf8584: Move 'ret' variable inside for loop,
 break if ret < 0.

> Require spaces around '=', '>' and '<'. Add space(s) around binary
> operators.
> Move 'ret' variable inside for loop. Then check if (ret < 0) break.
> This improves usage of ret variable.
…

Is there a need to split desirable adjustments into two update steps?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc1#n81

Regards,
Markus